chrome/browser/extensions/api/webstore_private/webstore_private_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webstore_private/webstore_private_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_logging_private/webrtc_logging_private_api_stub.cc ('k') | chrome/browser/extensions/api/webstore_private/webstore_private_api.cc » ('j') | extensions/browser/api/storage/storage_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webstore_private/webstore_private_api.h

diff --git a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

index 6c6cd452f65981d55c4bbf5edcbad50f8b1c15d6..d733319404be1cdf4ea0891eb286e6d67f9d9494 100644

--- a/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

+++ b/chrome/browser/extensions/api/webstore_private/webstore_private_api.h

@@ -63,7 +63,7 @@ class WebstorePrivateInstallBundleFunction

virtual ~WebstorePrivateInstallBundleFunction();

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// Reads the extension |details| into |items|.

bool ReadBundleInfo(

@@ -137,7 +137,7 @@ class WebstorePrivateBeginInstallWithManifest3Function

virtual ~WebstorePrivateBeginInstallWithManifest3Function();

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// Sets the result_ as a string based on |code|.

void SetResultCode(ResultCode code);

@@ -191,7 +191,7 @@ class WebstorePrivateCompleteInstallFunction

virtual ~WebstorePrivateCompleteInstallFunction();

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

private:

scoped_ptr<WebstoreInstaller::Approval> approval_;

@@ -265,7 +265,7 @@ class WebstorePrivateGetWebGLStatusFunction

void OnFeatureCheck(bool feature_allowed);

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

private:

void CreateResult(bool webgl_allowed);

@@ -319,7 +319,7 @@ class WebstorePrivateSignInFunction : public ChromeAsyncExtensionFunction,

virtual ~WebstorePrivateSignInFunction();

// ExtensionFunction:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// SigninManagerFactory::Observer:

virtual void SigninManagerShutdown(SigninManagerBase* manager) OVERRIDE;