chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc » ('j') | extensions/browser/api/storage/storage_api.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h

diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h

index be4a9e8305866cc8bd31312b08a62635236479ab..be981545f6ba92671e683f03e1f24dc513639436 100644

--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h

+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h

@@ -117,7 +117,7 @@ class WebrtcAudioPrivateGetSinksFunction : public WebrtcAudioPrivateFunction {

// Sequence of events is that we query the list of sinks on the

// AudioManager's thread, then calculate HMACs on the IO thread,

// then finish on the UI thread.

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

void DoQuery();

virtual void OnOutputDeviceNames(

scoped_ptr<media::AudioDeviceNames> raw_ids) OVERRIDE;

@@ -133,7 +133,7 @@ class WebrtcAudioPrivateGetActiveSinkFunction

DECLARE_EXTENSION_FUNCTION("webrtcAudioPrivate.getActiveSink",

WEBRTC_AUDIO_PRIVATE_GET_ACTIVE_SINK);

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

virtual void OnControllerList(

const content::RenderViewHost::AudioOutputControllerList&

controllers) OVERRIDE;

@@ -152,7 +152,7 @@ class WebrtcAudioPrivateSetActiveSinkFunction

DECLARE_EXTENSION_FUNCTION("webrtcAudioPrivate.setActiveSink",

WEBRTC_AUDIO_PRIVATE_SET_ACTIVE_SINK);

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

virtual void OnControllerList(

const content::RenderViewHost::AudioOutputControllerList&

controllers) OVERRIDE;

@@ -184,7 +184,7 @@ class WebrtcAudioPrivateGetAssociatedSinkFunction

DECLARE_EXTENSION_FUNCTION("webrtcAudioPrivate.getAssociatedSink",

WEBRTC_AUDIO_PRIVATE_GET_ASSOCIATED_SINK);

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// This implementation is slightly complicated because of different

// thread requirements for the various functions we need to invoke.