chrome/browser/extensions/api/tabs/tabs_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/tabs_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/tabs_api.h

diff --git a/chrome/browser/extensions/api/tabs/tabs_api.h b/chrome/browser/extensions/api/tabs/tabs_api.h

index 605fcb9c4d22674345c449c52c2bdb7a26bf9e50..720b93c3db81c0c5726a93ba8fe2c119a7be75b1 100644

--- a/chrome/browser/extensions/api/tabs/tabs_api.h

+++ b/chrome/browser/extensions/api/tabs/tabs_api.h

@@ -148,7 +148,7 @@ class TabsUpdateFunction : public ChromeAsyncExtensionFunction {

content::WebContents* web_contents_;

private:

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

void OnExecuteCodeFinished(const std::string& error,

int32 on_page_id,

const GURL& on_url,

@@ -181,7 +181,7 @@ class TabsDetectLanguageFunction : public ChromeAsyncExtensionFunction,

public content::NotificationObserver {

private:

virtual ~TabsDetectLanguageFunction() {}

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

virtual void Observe(int type,

const content::NotificationSource& source,