chrome/browser/extensions/api/serial/serial_apitest.cc - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/serial/serial_apitest.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/serial/serial_apitest.cc

diff --git a/chrome/browser/extensions/api/serial/serial_apitest.cc b/chrome/browser/extensions/api/serial/serial_apitest.cc

index a53bb800b597f3ca2c66dab60b948e26eeec83bb..6bdad96fcaae2b2699a1518d49c5545da3166311 100644

--- a/chrome/browser/extensions/api/serial/serial_apitest.cc

+++ b/chrome/browser/extensions/api/serial/serial_apitest.cc

@@ -36,7 +36,7 @@ namespace extensions {

class FakeSerialGetDevicesFunction : public AsyncExtensionFunction {

public:

- virtual bool RunImpl() OVERRIDE {

+ virtual bool RunAsync() OVERRIDE {

base::ListValue* devices = new base::ListValue();

base::DictionaryValue* device0 = new base::DictionaryValue();

device0->SetString("path", "/dev/fakeserial");