chrome/browser/extensions/api/runtime/runtime_api.h - Issue 257333002: Drive extension functions from ExtensionFunction::Run. The

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/runtime_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase, fix test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/runtime/runtime_api.h

diff --git a/chrome/browser/extensions/api/runtime/runtime_api.h b/chrome/browser/extensions/api/runtime/runtime_api.h

index 4bc411cefc646ceb424a004eb3ff56bdb1aacee9..f648be145339a15b6571cbcbfbc9e0fb1e5533ff 100644

--- a/chrome/browser/extensions/api/runtime/runtime_api.h

+++ b/chrome/browser/extensions/api/runtime/runtime_api.h

@@ -129,7 +129,7 @@ class RuntimeGetBackgroundPageFunction : public ChromeAsyncExtensionFunction {

protected:

virtual ~RuntimeGetBackgroundPageFunction() {}

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

private:

void OnPageLoaded(ExtensionHost*);

@@ -163,7 +163,7 @@ class RuntimeRequestUpdateCheckFunction : public ChromeAsyncExtensionFunction,

RuntimeRequestUpdateCheckFunction();

protected:

virtual ~RuntimeRequestUpdateCheckFunction() {}

- virtual bool RunImpl() OVERRIDE;

+ virtual bool RunAsync() OVERRIDE;

// Implements content::NotificationObserver interface.

virtual void Observe(int type,