Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4325)

Unified Diff: chrome/browser/extensions/api/management/management_api.h

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, fix test Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/management/management_api.h
diff --git a/chrome/browser/extensions/api/management/management_api.h b/chrome/browser/extensions/api/management/management_api.h
index c2f26d93a8283b620f40beab712616bf8e6fde03..25aaeffdd93067bdecbcaf85d4f5fed77c07a73d 100644
--- a/chrome/browser/extensions/api/management/management_api.h
+++ b/chrome/browser/extensions/api/management/management_api.h
@@ -83,7 +83,7 @@ class ManagementGetPermissionWarningsByManifestFunction
virtual ~ManagementGetPermissionWarningsByManifestFunction() {}
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
};
class ManagementLaunchAppFunction : public ManagementFunction {
@@ -108,7 +108,7 @@ class ManagementSetEnabledFunction : public AsyncManagementFunction,
virtual ~ManagementSetEnabledFunction();
// ExtensionFunction:
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
// ExtensionInstallPrompt::Delegate.
virtual void InstallUIProceed() OVERRIDE;
@@ -140,7 +140,7 @@ class ManagementUninstallFunctionBase : public AsyncManagementFunction,
// If should_uninstall is true, this method does the actual uninstall.
// If |show_uninstall_dialog|, then this function will be called by one of the
- // Accepted/Canceled callbacks. Otherwise, it's called directly from RunImpl.
+ // Accepted/Canceled callbacks. Otherwise, it's called directly from RunAsync.
void Finish(bool should_uninstall);
std::string extension_id_;
@@ -156,7 +156,7 @@ class ManagementUninstallFunction : public ManagementUninstallFunctionBase {
private:
virtual ~ManagementUninstallFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
};
class ManagementUninstallSelfFunction : public ManagementUninstallFunctionBase {
@@ -169,7 +169,7 @@ class ManagementUninstallSelfFunction : public ManagementUninstallFunctionBase {
private:
virtual ~ManagementUninstallSelfFunction();
- virtual bool RunImpl() OVERRIDE;
+ virtual bool RunAsync() OVERRIDE;
};
class ManagementEventRouter : public content::NotificationObserver {

Powered by Google App Engine
This is Rietveld 408576698