Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: chrome/browser/extensions/api/preferences_private/preferences_private_api.cc

Issue 257333002: Drive extension functions from ExtensionFunction::Run. The (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix comment Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/preferences_private/preferences_private_ api.h" 5 #include "chrome/browser/extensions/api/preferences_private/preferences_private_ api.h"
6 6
7 #include "chrome/browser/profiles/profile.h" 7 #include "chrome/browser/profiles/profile.h"
8 #include "chrome/browser/sync/profile_sync_service.h" 8 #include "chrome/browser/sync/profile_sync_service.h"
9 #include "chrome/browser/sync/profile_sync_service_factory.h" 9 #include "chrome/browser/sync/profile_sync_service_factory.h"
10 #include "chrome/common/extensions/api/preferences_private.h" 10 #include "chrome/common/extensions/api/preferences_private.h"
11 #include "components/sync_driver/sync_prefs.h" 11 #include "components/sync_driver/sync_prefs.h"
12 12
13 namespace extensions { 13 namespace extensions {
14 14
15 namespace GetSyncCategoriesWithoutPassphrase = 15 namespace GetSyncCategoriesWithoutPassphrase =
16 api::preferences_private::GetSyncCategoriesWithoutPassphrase; 16 api::preferences_private::GetSyncCategoriesWithoutPassphrase;
17 17
18 PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction:: 18 PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction::
19 PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction() {} 19 PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction() {}
20 20
21 PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction:: 21 PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction::
22 ~PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction() {} 22 ~PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction() {}
23 23
24 void 24 void
25 PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction::OnStateChanged() { 25 PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction::OnStateChanged() {
26 ProfileSyncService* sync_service = 26 ProfileSyncService* sync_service =
27 ProfileSyncServiceFactory::GetForProfile(GetProfile()); 27 ProfileSyncServiceFactory::GetForProfile(GetProfile());
28 if (sync_service->sync_initialized()) { 28 if (sync_service->sync_initialized()) {
29 sync_service->RemoveObserver(this); 29 sync_service->RemoveObserver(this);
30 RunImpl(); 30 RunAsync();
31 Release(); // Balanced in RunImpl(). 31 Release(); // Balanced in RunAsync().
32 } 32 }
33 } 33 }
34 34
35 bool PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction::RunImpl() { 35 bool PreferencesPrivateGetSyncCategoriesWithoutPassphraseFunction::RunAsync() {
36 ProfileSyncService* sync_service = 36 ProfileSyncService* sync_service =
37 ProfileSyncServiceFactory::GetForProfile(GetProfile()); 37 ProfileSyncServiceFactory::GetForProfile(GetProfile());
38 if (!sync_service) 38 if (!sync_service)
39 return false; 39 return false;
40 if (!sync_service->sync_initialized()) { 40 if (!sync_service->sync_initialized()) {
41 AddRef(); // Balanced in OnStateChanged(). 41 AddRef(); // Balanced in OnStateChanged().
42 sync_service->AddObserver(this); 42 sync_service->AddObserver(this);
43 return true; 43 return true;
44 } 44 }
45 45
(...skipping 14 matching lines...) Expand all
60 it.Inc()) { 60 it.Inc()) {
61 categories.push_back(syncer::ModelTypeToString(it.Get())); 61 categories.push_back(syncer::ModelTypeToString(it.Get()));
62 } 62 }
63 63
64 results_ = GetSyncCategoriesWithoutPassphrase::Results::Create(categories); 64 results_ = GetSyncCategoriesWithoutPassphrase::Results::Create(categories);
65 SendResponse(true); 65 SendResponse(true);
66 return true; 66 return true;
67 } 67 }
68 68
69 } // namespace extensions 69 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698