Drive extension functions from ExtensionFunction::Run. The

chrome/browser/extensions/api/webview/webview_api.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/webview/webview_api.h"
 
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/extensions/api/browsing_data/browsing_data_api.h"
 #include "chrome/browser/extensions/api/context_menus/context_menus_api.h"
 #include "chrome/browser/extensions/api/context_menus/context_menus_api_helpers.h"
@@ skipping 28 matching lines @@
     return content::StoragePartition::REMOVE_DATA_MASK_INDEXEDDB;
   if (strcmp(key, extension_browsing_data_api_constants::kLocalStorageKey) == 0)
     return content::StoragePartition::REMOVE_DATA_MASK_LOCAL_STORAGE;
   if (strcmp(key, extension_browsing_data_api_constants::kWebSQLKey) == 0)
     return content::StoragePartition::REMOVE_DATA_MASK_WEBSQL;
   return 0;
 }
 
 }  // namespace
 
-bool WebviewExtensionFunction::RunImpl() {
+bool WebviewExtensionFunction::RunAsync() {
   int instance_id = 0;
   EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &instance_id));
   WebViewGuest* guest = WebViewGuest::From(
       render_view_host()->GetProcess()->GetID(), instance_id);
   if (!guest)
     return false;
 
-  return RunImplSafe(guest);
+  return RunAsyncSafe(guest);
 }
 
 // TODO(lazyboy): Add checks similar to
-// WebviewExtensionFunction::RunImplSafe(WebViewGuest*).
-bool WebviewContextMenusCreateFunction::RunImpl() {
+// WebviewExtensionFunction::RunAsyncSafe(WebViewGuest*).
+bool WebviewContextMenusCreateFunction::RunAsync() {
   scoped_ptr<webview::ContextMenusCreate::Params> params(
       webview::ContextMenusCreate::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   MenuItem::Id id(
       Profile::FromBrowserContext(browser_context())->IsOffTheRecord(),
       MenuItem::ExtensionKey(extension_id(), params->instance_id));
 
   if (params->create_properties.id.get()) {
     id.string_uid = *params->create_properties.id;
   } else {
     // The Generated Id is added by webview_custom_bindings.js.
     base::DictionaryValue* properties = NULL;
     EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(1, &properties));
     EXTENSION_FUNCTION_VALIDATE(
         properties->GetInteger(helpers::kGeneratedIdKey, &id.uid));
   }
 
   bool success = extensions::context_menus_api_helpers::CreateMenuItem(
       params->create_properties,
       Profile::FromBrowserContext(browser_context()),
       GetExtension(),
       id,
       &error_);
 
   SendResponse(success);
   return success;
 }
 
-bool WebviewContextMenusUpdateFunction::RunImpl() {
+bool WebviewContextMenusUpdateFunction::RunAsync() {
   scoped_ptr<webview::ContextMenusUpdate::Params> params(
       webview::ContextMenusUpdate::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   Profile* profile = Profile::FromBrowserContext(browser_context());
   MenuItem::Id item_id(
       profile->IsOffTheRecord(),
       MenuItem::ExtensionKey(extension_id(), params->instance_id));
 
   if (params->id.as_string)
     item_id.string_uid = *params->id.as_string;
   else if (params->id.as_integer)
     item_id.uid = *params->id.as_integer;
   else
     NOTREACHED();
 
   bool success = extensions::context_menus_api_helpers::UpdateMenuItem(
       params->update_properties, profile, GetExtension(), item_id, &error_);
   SendResponse(success);
   return success;
 }
 
-bool WebviewContextMenusRemoveFunction::RunImpl() {
+bool WebviewContextMenusRemoveFunction::RunAsync() {
   scoped_ptr<webview::ContextMenusRemove::Params> params(
       webview::ContextMenusRemove::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   MenuManager* menu_manager =
       MenuManager::Get(Profile::FromBrowserContext(browser_context()));
 
   MenuItem::Id id(
       Profile::FromBrowserContext(browser_context())->IsOffTheRecord(),
       MenuItem::ExtensionKey(extension_id(), params->instance_id));
@@ skipping 15 matching lines @@
         context_menus_api_helpers::GetIDString(id));
     success = false;
   } else if (!menu_manager->RemoveContextMenuItem(id)) {
     success = false;
   }
 
   SendResponse(success);
   return success;
 }
 
-bool WebviewContextMenusRemoveAllFunction::RunImpl() {
+bool WebviewContextMenusRemoveAllFunction::RunAsync() {
   scoped_ptr<webview::ContextMenusRemoveAll::Params> params(
       webview::ContextMenusRemoveAll::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   MenuManager* menu_manager =
       MenuManager::Get(Profile::FromBrowserContext(browser_context()));
 
   int webview_instance_id = params->instance_id;
   menu_manager->RemoveAllContextItems(
       MenuItem::ExtensionKey(GetExtension()->id(), webview_instance_id));
@@ skipping 27 matching lines @@
     }
     if (selected)
       remove_mask |= MaskForKey(i.key().c_str());
   }
 
   return remove_mask;
 }
 
 // TODO(lazyboy): Parameters in this extension function are similar (or a
 // sub-set) to BrowsingDataRemoverFunction. How can we share this code?
-bool WebviewClearDataFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewClearDataFunction::RunAsyncSafe(WebViewGuest* guest) {
   // Grab the initial |options| parameter, and parse out the arguments.
   base::DictionaryValue* options;
   EXTENSION_FUNCTION_VALIDATE(args_->GetDictionary(1, &options));
   DCHECK(options);
 
   // If |ms_since_epoch| isn't set, default it to 0.
   double ms_since_epoch;
   if (!options->GetDouble(extension_browsing_data_api_constants::kSinceKey,
                           &ms_since_epoch)) {
     ms_since_epoch = 0;
@@ skipping 25 matching lines @@
     SendResponse(false);
     Release();  // Balanced above.
     return false;
   }
 
   // Will finish asynchronously.
   return true;
 }
 
 void WebviewClearDataFunction::ClearDataDone() {
-  Release();  // Balanced in RunImpl().
+  Release();  // Balanced in RunAsync().
   SendResponse(true);
 }
 
 WebviewExecuteCodeFunction::WebviewExecuteCodeFunction()
     : guest_instance_id_(0), guest_src_(GURL::EmptyGURL()) {}
 
 WebviewExecuteCodeFunction::~WebviewExecuteCodeFunction() {
 }
 
 bool WebviewExecuteCodeFunction::Init() {
@@ skipping 92 matching lines @@
     FailureReason reason) {
   SendResponse(false);
 }
 
 WebviewSetZoomFunction::WebviewSetZoomFunction() {
 }
 
 WebviewSetZoomFunction::~WebviewSetZoomFunction() {
 }
 
-bool WebviewSetZoomFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewSetZoomFunction::RunAsyncSafe(WebViewGuest* guest) {
   scoped_ptr<webview::SetZoom::Params> params(
       webview::SetZoom::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
   guest->SetZoom(params->zoom_factor);
 
   SendResponse(true);
   return true;
 }
 
 WebviewGetZoomFunction::WebviewGetZoomFunction() {
 }
 
 WebviewGetZoomFunction::~WebviewGetZoomFunction() {
 }
 
-bool WebviewGetZoomFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewGetZoomFunction::RunAsyncSafe(WebViewGuest* guest) {
   scoped_ptr<webview::GetZoom::Params> params(
       webview::GetZoom::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   double zoom_factor = guest->GetZoom();
   SetResult(base::Value::CreateDoubleValue(zoom_factor));
   SendResponse(true);
   return true;
 }
 
 WebviewFindFunction::WebviewFindFunction() {
 }
 
 WebviewFindFunction::~WebviewFindFunction() {
 }
 
-bool WebviewFindFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewFindFunction::RunAsyncSafe(WebViewGuest* guest) {
   scoped_ptr<webview::Find::Params> params(
       webview::Find::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   // Convert the std::string search_text to string16.
   base::string16 search_text;
   base::UTF8ToUTF16(params->search_text.c_str(),
                     params->search_text.length(),
                     &search_text);
 
   // Set the find options to their default values.
   blink::WebFindOptions options;
   if (params->options) {
     options.forward =
         params->options->backward ? !*params->options->backward : true;
     options.matchCase =
         params->options->match_case ? *params->options->match_case : false;
   }
 
   guest->Find(search_text, options, this);
   return true;
 }
 
 WebviewStopFindingFunction::WebviewStopFindingFunction() {
 }
 
 WebviewStopFindingFunction::~WebviewStopFindingFunction() {
 }
 
-bool WebviewStopFindingFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewStopFindingFunction::RunAsyncSafe(WebViewGuest* guest) {
   scoped_ptr<webview::StopFinding::Params> params(
       webview::StopFinding::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   // Set the StopFindAction.
   content::StopFindAction action;
   switch (params->action) {
     case webview::StopFinding::Params::ACTION_CLEAR:
       action = content::STOP_FIND_ACTION_CLEAR_SELECTION;
       break;
@@ skipping 10 matching lines @@
   guest->StopFinding(action);
   return true;
 }
 
 WebviewGoFunction::WebviewGoFunction() {
 }
 
 WebviewGoFunction::~WebviewGoFunction() {
 }
 
-bool WebviewGoFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewGoFunction::RunAsyncSafe(WebViewGuest* guest) {
   scoped_ptr<webview::Go::Params> params(webview::Go::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   guest->Go(params->relative_index);
   return true;
 }
 
 WebviewReloadFunction::WebviewReloadFunction() {
 }
 
 WebviewReloadFunction::~WebviewReloadFunction() {
 }
 
-bool WebviewReloadFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewReloadFunction::RunAsyncSafe(WebViewGuest* guest) {
   guest->Reload();
   return true;
 }
 
 WebviewSetPermissionFunction::WebviewSetPermissionFunction() {
 }
 
 WebviewSetPermissionFunction::~WebviewSetPermissionFunction() {
 }
 
-bool WebviewSetPermissionFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewSetPermissionFunction::RunAsyncSafe(WebViewGuest* guest) {
   scoped_ptr<webview::SetPermission::Params> params(
       webview::SetPermission::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   WebViewGuest::PermissionResponseAction action = WebViewGuest::DEFAULT;
   switch (params->action) {
     case Params::ACTION_ALLOW:
       action = WebViewGuest::ALLOW;
       break;
     case Params::ACTION_DENY:
@@ skipping 19 matching lines @@
   SendResponse(true);
   return true;
 }
 
 WebviewOverrideUserAgentFunction::WebviewOverrideUserAgentFunction() {
 }
 
 WebviewOverrideUserAgentFunction::~WebviewOverrideUserAgentFunction() {
 }
 
-bool WebviewOverrideUserAgentFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewOverrideUserAgentFunction::RunAsyncSafe(WebViewGuest* guest) {
   scoped_ptr<extensions::api::webview::OverrideUserAgent::Params> params(
       extensions::api::webview::OverrideUserAgent::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   guest->SetUserAgentOverride(params->user_agent_override);
   return true;
 }
 
 WebviewStopFunction::WebviewStopFunction() {
 }
 
 WebviewStopFunction::~WebviewStopFunction() {
 }
 
-bool WebviewStopFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewStopFunction::RunAsyncSafe(WebViewGuest* guest) {
   guest->Stop();
   return true;
 }
 
 WebviewTerminateFunction::WebviewTerminateFunction() {
 }
 
 WebviewTerminateFunction::~WebviewTerminateFunction() {
 }
 
-bool WebviewTerminateFunction::RunImplSafe(WebViewGuest* guest) {
+bool WebviewTerminateFunction::RunAsyncSafe(WebViewGuest* guest) {
   guest->Terminate();
   return true;
 }
 
 }  // namespace extensions