Drive extension functions from ExtensionFunction::Run. The

chrome/browser/extensions/api/webstore_private/webstore_private_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/webstore_private/webstore_private_api.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_vector.h"
@@ skipping 197 matching lines @@
 // static
 scoped_ptr<WebstoreInstaller::Approval>
 WebstorePrivateApi::PopApprovalForTesting(
     Profile* profile, const std::string& extension_id) {
   return g_pending_approvals.Get().PopApproval(profile, extension_id);
 }
 
 WebstorePrivateInstallBundleFunction::WebstorePrivateInstallBundleFunction() {}
 WebstorePrivateInstallBundleFunction::~WebstorePrivateInstallBundleFunction() {}
 
-bool WebstorePrivateInstallBundleFunction::RunImpl() {
+bool WebstorePrivateInstallBundleFunction::RunAsync() {
   scoped_ptr<InstallBundle::Params> params(
       InstallBundle::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
 
   BundleInstaller::ItemList items;
   if (!ReadBundleInfo(*params, &items))
     return false;
 
   bundle_ = new BundleInstaller(GetCurrentBrowser(), items);
 
@@ skipping 25 matching lines @@
 
 void WebstorePrivateInstallBundleFunction::OnBundleInstallCanceled(
     bool user_initiated) {
   if (user_initiated)
     error_ = "user_canceled";
   else
     error_ = "unknown_error";
 
   SendResponse(false);
 
-  Release();  // Balanced in RunImpl().
+  Release();  // Balanced in RunAsync().
 }
 
 void WebstorePrivateInstallBundleFunction::OnBundleInstallCompleted() {
   SendResponse(true);
 
-  Release();  // Balanced in RunImpl().
+  Release();  // Balanced in RunAsync().
 }
 
 WebstorePrivateBeginInstallWithManifest3Function::
     WebstorePrivateBeginInstallWithManifest3Function() {}
 
 WebstorePrivateBeginInstallWithManifest3Function::
     ~WebstorePrivateBeginInstallWithManifest3Function() {}
 
-bool WebstorePrivateBeginInstallWithManifest3Function::RunImpl() {
+bool WebstorePrivateBeginInstallWithManifest3Function::RunAsync() {
   params_ = BeginInstallWithManifest3::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params_);
 
   if (!extensions::Extension::IdIsValid(params_->details.id)) {
     SetResultCode(INVALID_ID);
     error_ = kInvalidIdError;
     return false;
   }
 
   if (params_->details.icon_data && params_->details.icon_url) {
@@ skipping 137 matching lines @@
     case WebstoreInstallHelper::Delegate::MANIFEST_ERROR:
       SetResultCode(MANIFEST_ERROR);
       break;
     default:
       CHECK(false);
   }
   error_ = error_message;
   g_pending_installs.Get().EraseInstall(GetProfile(), id);
   SendResponse(false);
 
-  // Matches the AddRef in RunImpl().
+  // Matches the AddRef in RunAsync().
   Release();
 }
 
 void WebstorePrivateBeginInstallWithManifest3Function::SigninFailed(
     const GoogleServiceAuthError& error) {
   signin_tracker_.reset();
 
   SetResultCode(SIGNIN_FAILED);
   error_ = error.ToString();
   g_pending_installs.Get().EraseInstall(GetProfile(), params_->details.id);
   SendResponse(false);
 
-  // Matches the AddRef in RunImpl().
+  // Matches the AddRef in RunAsync().
   Release();
 }
 
 void WebstorePrivateBeginInstallWithManifest3Function::SigninSuccess() {
   signin_tracker_.reset();
 
   SigninCompletedOrNotNeeded();
 }
 
 void WebstorePrivateBeginInstallWithManifest3Function::MergeSessionComplete(
@@ skipping 35 matching lines @@
 
   SetResultCode(ERROR_NONE);
   SendResponse(true);
 
   // The Permissions_Install histogram is recorded from the ExtensionService
   // for all extension installs, so we only need to record the web store
   // specific histogram here.
   ExtensionService::RecordPermissionMessagesHistogram(
       dummy_extension_.get(), "Extensions.Permissions_WebStoreInstall");
 
-  // Matches the AddRef in RunImpl().
+  // Matches the AddRef in RunAsync().
   Release();
 }
 
 void WebstorePrivateBeginInstallWithManifest3Function::InstallUIAbort(
     bool user_initiated) {
   error_ = kUserCancelledError;
   SetResultCode(USER_CANCELLED);
   g_pending_installs.Get().EraseInstall(GetProfile(), params_->details.id);
   SendResponse(false);
 
   // The web store install histograms are a subset of the install histograms.
   // We need to record both histograms here since CrxInstaller::InstallUIAbort
   // is never called for web store install cancellations.
   std::string histogram_name = user_initiated ?
       "Extensions.Permissions_WebStoreInstallCancel" :
       "Extensions.Permissions_WebStoreInstallAbort";
   ExtensionService::RecordPermissionMessagesHistogram(dummy_extension_.get(),
                                                       histogram_name.c_str());
 
   histogram_name = user_initiated ?
       "Extensions.Permissions_InstallCancel" :
       "Extensions.Permissions_InstallAbort";
   ExtensionService::RecordPermissionMessagesHistogram(dummy_extension_.get(),
                                                       histogram_name.c_str());
 
-  // Matches the AddRef in RunImpl().
+  // Matches the AddRef in RunAsync().
   Release();
 }
 
 WebstorePrivateCompleteInstallFunction::
     WebstorePrivateCompleteInstallFunction() {}
 
 WebstorePrivateCompleteInstallFunction::
     ~WebstorePrivateCompleteInstallFunction() {}
 
-bool WebstorePrivateCompleteInstallFunction::RunImpl() {
+bool WebstorePrivateCompleteInstallFunction::RunAsync() {
   scoped_ptr<CompleteInstall::Params> params(
       CompleteInstall::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params);
   if (!extensions::Extension::IdIsValid(params->expected_id)) {
     error_ = kInvalidIdError;
     return false;
   }
 
   approval_ = g_pending_approvals.Get()
                   .PopApproval(GetProfile(), params->expected_id)
@@ skipping 41 matching lines @@
     const std::string& id) {
   if (test_webstore_installer_delegate)
     test_webstore_installer_delegate->OnExtensionInstallSuccess(id);
 
   VLOG(1) << "Install success, sending response";
   g_pending_installs.Get().EraseInstall(GetProfile(), id);
   SendResponse(true);
 
   RecordWebstoreExtensionInstallResult(true);
 
-  // Matches the AddRef in RunImpl().
+  // Matches the AddRef in RunAsync().
   Release();
 }
 
 void WebstorePrivateCompleteInstallFunction::OnExtensionInstallFailure(
     const std::string& id,
     const std::string& error,
     WebstoreInstaller::FailureReason reason) {
   if (test_webstore_installer_delegate) {
     test_webstore_installer_delegate->OnExtensionInstallFailure(
         id, error, reason);
   }
 
   error_ = error;
   VLOG(1) << "Install failed, sending response";
   g_pending_installs.Get().EraseInstall(GetProfile(), id);
   SendResponse(false);
 
   RecordWebstoreExtensionInstallResult(false);
 
-  // Matches the AddRef in RunImpl().
+  // Matches the AddRef in RunAsync().
   Release();
 }
 
 WebstorePrivateEnableAppLauncherFunction::
     WebstorePrivateEnableAppLauncherFunction() {}
 
 WebstorePrivateEnableAppLauncherFunction::
     ~WebstorePrivateEnableAppLauncherFunction() {}
 
 bool WebstorePrivateEnableAppLauncherFunction::RunSync() {
@@ skipping 31 matching lines @@
 }
 
 WebstorePrivateGetWebGLStatusFunction::
     ~WebstorePrivateGetWebGLStatusFunction() {}
 
 void WebstorePrivateGetWebGLStatusFunction::CreateResult(bool webgl_allowed) {
   results_ = GetWebGLStatus::Results::Create(GetWebGLStatus::Results::
       ParseWebgl_status(webgl_allowed ? "webgl_allowed" : "webgl_blocked"));
 }
 
-bool WebstorePrivateGetWebGLStatusFunction::RunImpl() {
+bool WebstorePrivateGetWebGLStatusFunction::RunAsync() {
   feature_checker_->CheckGPUFeatureAvailability();
   return true;
 }
 
 void WebstorePrivateGetWebGLStatusFunction::
     OnFeatureCheck(bool feature_allowed) {
   CreateResult(feature_allowed);
   SendResponse(true);
 }
 
 bool WebstorePrivateGetIsLauncherEnabledFunction::RunSync() {
   results_ = GetIsLauncherEnabled::Results::Create(IsAppLauncherEnabled());
   return true;
 }
 
 bool WebstorePrivateIsInIncognitoModeFunction::RunSync() {
   results_ = IsInIncognitoMode::Results::Create(
       GetProfile() != GetProfile()->GetOriginalProfile());
   return true;
 }
 
 WebstorePrivateSignInFunction::WebstorePrivateSignInFunction()
     : signin_manager_(NULL) {}
 WebstorePrivateSignInFunction::~WebstorePrivateSignInFunction() {}
 
-bool WebstorePrivateSignInFunction::RunImpl() {
+bool WebstorePrivateSignInFunction::RunAsync() {
   scoped_ptr<SignIn::Params> params = SignIn::Params::Create(*args_);
   EXTENSION_FUNCTION_VALIDATE(params);
 
   // This API must be called only in response to a user gesture.
   if (!user_gesture()) {
     error_ = "user_gesture_required";
     SendResponse(false);
     return false;
   }
 
@@ skipping 52 matching lines @@
   if (manager == signin_manager_)
     SigninFailed(GoogleServiceAuthError::AuthErrorNone());
 }
 
 void WebstorePrivateSignInFunction::SigninFailed(
     const GoogleServiceAuthError& error) {
   error_ = "signin_failed";
   SendResponse(false);
 
   SigninManagerFactory::GetInstance()->RemoveObserver(this);
-  Release();  // Balanced in RunImpl().
+  Release();  // Balanced in RunAsync().
 }
 
 void WebstorePrivateSignInFunction::SigninSuccess() {
   // Nothing to do yet. Keep waiting until MergeSessionComplete() is called.
 }
 
 void WebstorePrivateSignInFunction::MergeSessionComplete(
     const GoogleServiceAuthError& error) {
   if (error.state() == GoogleServiceAuthError::NONE) {
     SendResponse(true);
   } else {
     error_ = "merge_session_failed";
     SendResponse(false);
   }
 
   SigninManagerFactory::GetInstance()->RemoveObserver(this);
-  Release();  // Balanced in RunImpl().
+  Release();  // Balanced in RunAsync().
 }
 
 }  // namespace extensions