Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js

Issue 2573323002: Revert of [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js b/third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js
index 856470cd6d87e2f634799d5dece8875c443e7879..90c5f20f59f5a00d184505483e21a4d1366b676f 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js
@@ -110,13 +110,6 @@
}
/**
- * @param {?function(!Event):boolean} clickHandler
- */
- setClickHandler(clickHandler) {
- this._window.setClickHandler(clickHandler);
- }
-
- /**
* @param {number} zoomFactor
* @param {number} referencePoint
*/
@@ -192,13 +185,6 @@
}
/**
- * @param {?function(!Event):boolean} clickHandler
- */
- setClickHandler(clickHandler) {
- this._clickHandler = clickHandler;
- }
-
- /**
* @param {!Event} event
*/
_resizerElementStartDragging(event) {
@@ -254,7 +240,7 @@
delete this._overviewWindowSelector;
var clickThreshold = 3;
if (window.end - window.start < clickThreshold) {
- if (this._clickHandler && this._clickHandler.call(null, event))
+ if (this.dispatchEventToListeners(UI.OverviewGrid.Events.Click, event))
return;
var middle = window.end;
window.start = Math.max(0, middle - UI.OverviewGrid.MinSelectableSize / 2);
@@ -419,7 +405,8 @@
/** @enum {symbol} */
UI.OverviewGrid.Events = {
- WindowChanged: Symbol('WindowChanged')
+ WindowChanged: Symbol('WindowChanged'),
+ Click: Symbol('Click')
};
/**

Powered by Google App Engine
This is Rietveld 408576698