Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2573323002: Revert of [DevTools] Remove methods on Common.Event. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {UI.ContextFlavorListener} 5 * @implements {UI.ContextFlavorListener}
6 * @implements {SDK.TargetManager.Observer} 6 * @implements {SDK.TargetManager.Observer}
7 * @implements {UI.ToolbarItem.ItemsProvider} 7 * @implements {UI.ToolbarItem.ItemsProvider}
8 * @unrestricted 8 * @unrestricted
9 */ 9 */
10 Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP aneBase { 10 Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP aneBase {
11 constructor() { 11 constructor() {
12 super(); 12 super();
13 this._xhrBreakpointsSetting = Common.settings.createLocalSetting('xhrBreakpo ints', []); 13 this._xhrBreakpointsSetting = Common.settings.createLocalSetting('xhrBreakpo ints', []);
14 14
15 /** @type {!Map.<string, !Element>} */ 15 /** @type {!Map.<string, !Element>} */
16 this._breakpointElements = new Map(); 16 this._breakpointElements = new Map();
17 17
18 this._addButton = new UI.ToolbarButton(Common.UIString('Add breakpoint'), 'l argeicon-add'); 18 this._addButton = new UI.ToolbarButton(Common.UIString('Add breakpoint'), 'l argeicon-add');
19 this._addButton.addEventListener(UI.ToolbarButton.Events.Click, this._addBut tonClicked.bind(this)); 19 this._addButton.addEventListener('click', this._addButtonClicked.bind(this)) ;
20 20
21 this.emptyElement.addEventListener('contextmenu', this._emptyElementContextM enu.bind(this), true); 21 this.emptyElement.addEventListener('contextmenu', this._emptyElementContextM enu.bind(this), true);
22 SDK.targetManager.observeTargets(this, SDK.Target.Capability.Browser); 22 SDK.targetManager.observeTargets(this, SDK.Target.Capability.Browser);
23 this._update(); 23 this._update();
24 } 24 }
25 25
26 /** 26 /**
27 * @override 27 * @override
28 * @param {!SDK.Target} target 28 * @param {!SDK.Target} target
29 */ 29 */
(...skipping 15 matching lines...) Expand all
45 toolbarItems() { 45 toolbarItems() {
46 return [this._addButton]; 46 return [this._addButton];
47 } 47 }
48 48
49 _emptyElementContextMenu(event) { 49 _emptyElementContextMenu(event) {
50 var contextMenu = new UI.ContextMenu(event); 50 var contextMenu = new UI.ContextMenu(event);
51 contextMenu.appendItem(Common.UIString.capitalize('Add ^breakpoint'), this._ addButtonClicked.bind(this)); 51 contextMenu.appendItem(Common.UIString.capitalize('Add ^breakpoint'), this._ addButtonClicked.bind(this));
52 contextMenu.show(); 52 contextMenu.show();
53 } 53 }
54 54
55 _addButtonClicked() { 55 _addButtonClicked(event) {
56 if (event)
57 event.consume();
58
56 UI.viewManager.showView('sources.xhrBreakpoints'); 59 UI.viewManager.showView('sources.xhrBreakpoints');
57 60
58 var inputElementContainer = createElementWithClass('p', 'breakpoint-conditio n'); 61 var inputElementContainer = createElementWithClass('p', 'breakpoint-conditio n');
59 inputElementContainer.textContent = Common.UIString('Break when URL contains :'); 62 inputElementContainer.textContent = Common.UIString('Break when URL contains :');
60 63
61 var inputElement = inputElementContainer.createChild('span', 'editing'); 64 var inputElement = inputElementContainer.createChild('span', 'editing');
62 inputElement.id = 'breakpoint-condition-input'; 65 inputElement.id = 'breakpoint-condition-input';
63 this.addListElement(inputElementContainer, /** @type {?Element} */ (this.lis tElement.firstChild)); 66 this.addListElement(inputElementContainer, /** @type {?Element} */ (this.lis tElement.firstChild));
64 67
65 /** 68 /**
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 */ 248 */
246 _restoreBreakpoints(target) { 249 _restoreBreakpoints(target) {
247 var breakpoints = this._xhrBreakpointsSetting.get(); 250 var breakpoints = this._xhrBreakpointsSetting.get();
248 for (var i = 0; i < breakpoints.length; ++i) { 251 for (var i = 0; i < breakpoints.length; ++i) {
249 var breakpoint = breakpoints[i]; 252 var breakpoint = breakpoints[i];
250 if (breakpoint && typeof breakpoint.url === 'string') 253 if (breakpoint && typeof breakpoint.url === 'string')
251 this._setBreakpoint(breakpoint.url, breakpoint.enabled, target); 254 this._setBreakpoint(breakpoint.url, breakpoint.enabled, target);
252 } 255 }
253 } 256 }
254 }; 257 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698