Issue 25733002: Fix crash reporting of child process command line switches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 25733002: Fix crash reporting of child process command line switches. (Closed)

Created:
7 years, 2 months ago by Robert Sesek

Modified:
7 years, 2 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix crash reporting of child process command line switches. It's not immediatley clear to me how this broke, since I converted all the callsites of the old method. However I've verified on each platform that this now reports command line switches properly. BUG=77656, 298225 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226519

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+113 lines, -1 line)			Patch
M	chrome/app/chrome_main_delegate.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/common/crash_keys.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A	chrome/common/crash_keys_unittest.cc	View	1 chunk	+99 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsesek@chromium.org/25733002/1

7 years, 2 months ago (2013-10-02 16:02:25 UTC) #3

Message was sent while issue was closed.

Change committed as 226519

Expand Messages | Collapse Messages