Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: services/catalog/store.h

Issue 2573283002: Use a static catalog manifest for the standalone Mash runner (Closed)
Patch Set: . Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/catalog/reader.cc ('k') | services/service_manager/background/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/catalog/store.h
diff --git a/services/catalog/store.h b/services/catalog/store.h
index 2a64e14645c8c8963685dfbcb4efa0a3f382ce0f..46a2bc564edfb4a15546eefb1da58624f507866d 100644
--- a/services/catalog/store.h
+++ b/services/catalog/store.h
@@ -5,15 +5,10 @@
#ifndef SERVICES_CATALOG_STORE_H_
#define SERVICES_CATALOG_STORE_H_
-#include <memory>
-
-#include "base/values.h"
-
namespace catalog {
-// Implemented by an object that provides storage for the service catalog
-// (e.g. in Chrome, preferences). The Catalog is the canonical owner of the
-// contents of the store, so no one else must modify its contents.
+// TODO(rockot): Clean this up now that it's only a namespace for constants.
+// Alternatively, re-introduce a Store interface once it makes sense to do so.
class Store {
public:
// Value is a string.
@@ -30,18 +25,6 @@ class Store {
static const char kInterfaceProviderSpecs_RequiresKey[];
// Value is a list.
static const char kServicesKey[];
-
- virtual ~Store() {}
-
- // Called during initialization to construct the Catalog's catalog.
- // Returns a serialized list of the services. Each entry in the returned list
- // corresponds to an app (as a dictionary). Each dictionary has a name,
- // display name and capabilities. The return value is owned by the caller.
- virtual const base::ListValue* GetStore() = 0;
-
- // Write the catalog to the store. Called when the Catalog learns of a newly
- // encountered service.
- virtual void UpdateStore(std::unique_ptr<base::ListValue> store) = 0;
};
} // namespace catalog
« no previous file with comments | « services/catalog/reader.cc ('k') | services/service_manager/background/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698