Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: media/base/android/demuxer_android.h

Issue 257323003: Remove the IPC to request DemuxerConfigs when config changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nits Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/android/demuxer_android.h
diff --git a/media/base/android/demuxer_android.h b/media/base/android/demuxer_android.h
index 39dc30fe7e604a04f98c96e58a8d545ea727533c..c8e6ffca63b598e21674f2932e64ac8ca06e3d6e 100644
--- a/media/base/android/demuxer_android.h
+++ b/media/base/android/demuxer_android.h
@@ -25,9 +25,6 @@ class MEDIA_EXPORT DemuxerAndroid {
// Must be called prior to calling any other methods.
virtual void Initialize(DemuxerAndroidClient* client) = 0;
- // Called to request the current audio/video decoder configurations.
- virtual void RequestDemuxerConfigs() = 0;
-
// Called to request additional data from the demuxer.
virtual void RequestDemuxerData(media::DemuxerStream::Type type) = 0;
@@ -44,12 +41,7 @@ class MEDIA_EXPORT DemuxerAndroid {
// Defines the client callback interface.
class MEDIA_EXPORT DemuxerAndroidClient {
public:
- // Called in response to RequestDemuxerConfigs() and also when the demuxer has
- // initialized.
- //
- // TODO(scherkus): Perhaps clients should be required to call
- // RequestDemuxerConfigs() to initialize themselves instead of the demuxer
- // calling this method without being prompted.
+ // Called when the demuxer has initialized.
virtual void OnDemuxerConfigsAvailable(const DemuxerConfigs& params) = 0;
// Called in response to RequestDemuxerData().

Powered by Google App Engine
This is Rietveld 408576698