Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: media/capture/video/video_capture_device.cc

Issue 2573223002: [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct (Closed)
Patch Set: miu's comments Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/capture/video/video_capture_device.cc
diff --git a/media/capture/video/video_capture_device.cc b/media/capture/video/video_capture_device.cc
index 5da33f01b7c39fcde86833e000fc04a04bbfd3da..4c4f1bd23d058c1a0ec19898f818d9bd31374508 100644
--- a/media/capture/video/video_capture_device.cc
+++ b/media/capture/video/video_capture_device.cc
@@ -13,8 +13,25 @@
namespace media {
-VideoCaptureDevice::Client::Buffer::~Buffer() {
-}
+VideoCaptureDevice::Client::Buffer::Buffer() : id_(0), frame_feedback_id_(0) {}
+
+VideoCaptureDevice::Client::Buffer::Buffer(
+ int buffer_id,
+ int frame_feedback_id,
+ std::unique_ptr<HandleProvider> handle_provider,
+ std::unique_ptr<ScopedAccessPermission> buffer_read_write_permission)
+ : handle_provider(std::move(handle_provider)),
+ buffer_read_write_permission(std::move(buffer_read_write_permission)),
+ id_(buffer_id),
+ frame_feedback_id_(frame_feedback_id) {}
+
+VideoCaptureDevice::Client::Buffer::Buffer(
+ VideoCaptureDevice::Client::Buffer&& other) = default;
+
+VideoCaptureDevice::Client::Buffer::~Buffer() = default;
+
+VideoCaptureDevice::Client::Buffer& VideoCaptureDevice::Client::Buffer::
+operator=(VideoCaptureDevice::Client::Buffer&& other) = default;
VideoCaptureDevice::~VideoCaptureDevice() {
}
mcasas 2017/01/05 20:37:01 Can be put in l.37, and I think my clang-format do
chfremer 2017/01/05 22:44:48 Done.

Powered by Google App Engine
This is Rietveld 408576698