media/capture/video/video_capture_buffer_pool.h - Issue 2573223002: [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/video/video_capture_buffer_pool.h

Issue 2573223002: [Mojo Video Capture] Simplify media::VideoCaptureDevice::Client:Buffer to a struct (Closed)

Patch Set: miu's comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/capture/video/video_capture_buffer_pool.h

diff --git a/media/capture/video/video_capture_buffer_pool.h b/media/capture/video/video_capture_buffer_pool.h

index 2d049570f95fa2d2868de33b86b4d5661d3fef4d..e2230cce34672181cd4ebb9e6376013483cf236e 100644

--- a/media/capture/video/video_capture_buffer_pool.h

+++ b/media/capture/video/video_capture_buffer_pool.h

@@ -44,8 +44,8 @@ class CAPTURE_EXPORT VideoCaptureBufferPool

// One-time (per client/per-buffer) call to allow sharing |buffer_id|.

virtual mojo::ScopedSharedBufferHandle GetHandleForTransit(int buffer_id) = 0;

- // Try and obtain a BufferHandle for |buffer_id|.

- virtual std::unique_ptr<VideoCaptureBufferHandle> GetBufferHandle(

+ // Try and obtain a read/write access to the buffer.

+ virtual std::unique_ptr<VideoCaptureBufferHandle> GetReadWriteAccess(

int buffer_id) = 0;

// Reserve or allocate a buffer to support a packed frame of |dimensions| of