Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issue 25732002: Handlify GetPropertyWithFailedAccessCheck. (Closed)

Created:
7 years, 2 months ago by Yang
Modified:
7 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Handlify GetPropertyWithFailedAccessCheck. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17146

Patch Set 1 #

Total comments: 4

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -46 lines) Patch
M src/objects.h View 1 3 chunks +14 lines, -6 lines 0 comments Download
M src/objects.cc View 1 3 chunks +51 lines, -40 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
Please take a look.
7 years, 2 months ago (2013-10-02 14:35:24 UTC) #1
Michael Starzinger
LGTM if comments are addressed. https://codereview.chromium.org/25732002/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/25732002/diff/1/src/objects.cc#newcode510 src/objects.cc:510: Handle<Object> JSObject::GetPropertyWithCallback(Handle<JSObject> holder, nit: ...
7 years, 2 months ago (2013-10-02 18:39:53 UTC) #2
Yang
7 years, 2 months ago (2013-10-10 15:39:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r17146 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698