Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: chrome/browser/task_manager/sampling/task_group.cc

Issue 2573183002: Add process start time and CPU time columns to task manager (Closed)
Patch Set: Move ticks-Time and ticks-TimeDelta conversions to shared_sampler_win.cc Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/sampling/task_group.cc
diff --git a/chrome/browser/task_manager/sampling/task_group.cc b/chrome/browser/task_manager/sampling/task_group.cc
index 5e36d732e9aa5ba72c47acae6b1f78d2347114f9..ac905ee8efb3727549e04de826a34e6cd653419f 100644
--- a/chrome/browser/task_manager/sampling/task_group.cc
+++ b/chrome/browser/task_manager/sampling/task_group.cc
@@ -22,9 +22,10 @@ namespace {
// A mask for the refresh types that are done in the background thread.
const int kBackgroundRefreshTypesMask =
- REFRESH_TYPE_CPU |
- REFRESH_TYPE_MEMORY |
- REFRESH_TYPE_IDLE_WAKEUPS |
+ REFRESH_TYPE_CPU | REFRESH_TYPE_MEMORY | REFRESH_TYPE_IDLE_WAKEUPS |
+#if defined(OS_WIN)
+ REFRESH_TYPE_START_TIME | REFRESH_TYPE_CPU_TIME |
+#endif // defined(OS_WIN)
#if defined(OS_LINUX)
REFRESH_TYPE_FD_COUNT |
#endif // defined(OS_LINUX)
@@ -114,8 +115,12 @@ TaskGroup::TaskGroup(
shared_sampler_->RegisterCallbacks(
process_id_, base::Bind(&TaskGroup::OnIdleWakeupsRefreshDone,
weak_ptr_factory_.GetWeakPtr()),
- base::Bind(&TaskGroup::OnPhysicalMemoryUsageRefreshDone,
- weak_ptr_factory_.GetWeakPtr()));
+ base::Bind(&TaskGroup::OnPhysicalMemoryUsageRefreshDone,
+ weak_ptr_factory_.GetWeakPtr()),
+ base::Bind(&TaskGroup::OnStartTimeRefreshDone,
+ weak_ptr_factory_.GetWeakPtr()),
+ base::Bind(&TaskGroup::OnCpuTimeRefreshDone,
+ weak_ptr_factory_.GetWeakPtr()));
}
TaskGroup::~TaskGroup() {
@@ -253,6 +258,20 @@ void TaskGroup::OnCpuRefreshDone(double cpu_usage) {
OnBackgroundRefreshTypeFinished(REFRESH_TYPE_CPU);
}
+void TaskGroup::OnStartTimeRefreshDone(base::Time start_time) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+ start_time_ = start_time;
+ OnBackgroundRefreshTypeFinished(REFRESH_TYPE_START_TIME);
+}
+
+void TaskGroup::OnCpuTimeRefreshDone(base::TimeDelta cpu_time) {
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
+
+ cpu_time_ = cpu_time;
+ OnBackgroundRefreshTypeFinished(REFRESH_TYPE_CPU_TIME);
+}
+
void TaskGroup::OnPhysicalMemoryUsageRefreshDone(int64_t physical_bytes) {
#if defined(OS_WIN)
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

Powered by Google App Engine
This is Rietveld 408576698