Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2933)

Unified Diff: base/i18n/time_formatting.h

Issue 2573183002: Add process start time and CPU time columns to task manager (Closed)
Patch Set: Addess CR questions Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/i18n/time_formatting.h
diff --git a/base/i18n/time_formatting.h b/base/i18n/time_formatting.h
index 761dd98a5d427e8441b7b17405be2dcb39933a6b..c500ea45172d2fe3fd359d6bef2a24903eff4596 100644
--- a/base/i18n/time_formatting.h
+++ b/base/i18n/time_formatting.h
@@ -77,9 +77,28 @@ BASE_I18N_EXPORT string16 TimeFormatFriendlyDate(const Time& time);
// Formats a time duration of hours and minutes into various formats, e.g.,
// "3:07" or "3 hours, 7 minutes". See DurationFormatWidth for details.
-BASE_I18N_EXPORT string16 TimeDurationFormat(const TimeDelta& time,
+//
+// Please don't use width = DURATION_WIDTH_NUMERIC when the time duration
+// can possibly be larger than 24h, as the hour value will be cut below 24
+// after formatting.
+// TODO (chengx): fix function output when width = DURATION_WIDTH_NUMERIC
dcheng 2016/12/21 23:28:57 Nit: no space between TODO and (
chengx 2016/12/22 21:42:55 Done.
+// (http://crbug.com/675791)
+BASE_I18N_EXPORT string16 TimeDurationFormat(const TimeDelta time,
const DurationFormatWidth width);
+// Formats a time duration of hours, minutes and seconds into various formats,
+// e.g., "3:07:30" or "3 hours, 7 minutes, 30 seconds". See DurationFormatWidth
+// for details.
+//
+// Please don't use width = DURATION_WIDTH_NUMERIC when the time duration
+// can possibly be larger than 24h, as the hour value will be cut below 24
+// after formatting.
+// TODO (chengx): fix function output when width = DURATION_WIDTH_NUMERIC
+// (http://crbug.com/675791)
+BASE_I18N_EXPORT string16
+TimeDurationFormatWithSeconds(const TimeDelta time,
+ const DurationFormatWidth width);
+
// Gets the hour clock type of the current locale. e.g.
// k12HourClock (en-US).
// k24HourClock (en-GB).
« no previous file with comments | « no previous file | base/i18n/time_formatting.cc » ('j') | chrome/browser/task_manager/sampling/task_manager_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698