Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/task_manager/sampling/task_group.h

Issue 2573183002: Add process start time and CPU time columns to task manager (Closed)
Patch Set: Add TODO comment for a bug, which will be addressed in another CL. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_manager/sampling/task_group.h
diff --git a/chrome/browser/task_manager/sampling/task_group.h b/chrome/browser/task_manager/sampling/task_group.h
index 8013e72c4e00d2b5ddf2944ef5b3de8115cd54aa..a788b56599d9960ec9d7ccd76249e0ff779606ea 100644
--- a/chrome/browser/task_manager/sampling/task_group.h
+++ b/chrome/browser/task_manager/sampling/task_group.h
@@ -67,6 +67,8 @@ class TaskGroup {
bool empty() const { return tasks().empty(); }
double cpu_usage() const { return cpu_usage_; }
+ uint64_t start_time() const { return start_time_; }
+ uint64_t cpu_time() const { return cpu_time_; }
int64_t private_bytes() const { return memory_usage_.private_bytes; }
int64_t shared_bytes() const { return memory_usage_.shared_bytes; }
int64_t physical_bytes() const { return memory_usage_.physical_bytes; }
@@ -107,6 +109,10 @@ class TaskGroup {
void OnCpuRefreshDone(double cpu_usage);
+ void OnStartTimeRefreshDone(uint64_t start_time);
+
+ void OnCpuTimeRefreshDone(uint64_t cpu_time);
+
void OnPhysicalMemoryUsageRefreshDone(int64_t physical_bytes);
void OnMemoryUsageRefreshDone(MemoryUsageStats memory_usage);
@@ -143,6 +149,8 @@ class TaskGroup {
// The per process resources usages.
double cpu_usage_;
+ uint64_t start_time_;
+ uint64_t cpu_time_;
afakhry 2016/12/21 18:34:34 I think the units need to be documented here as we
chengx 2016/12/21 22:05:54 Done.
MemoryUsageStats memory_usage_;
int64_t gpu_memory_;
// The network usage in bytes per second as the sum of all network usages of

Powered by Google App Engine
This is Rietveld 408576698