Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3190)

Unified Diff: base/i18n/time_formatting.cc

Issue 2573183002: Add process start time and CPU time columns to task manager (Closed)
Patch Set: Add TODO comment for a bug, which will be addressed in another CL. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/i18n/time_formatting.cc
diff --git a/base/i18n/time_formatting.cc b/base/i18n/time_formatting.cc
index 024b86510b5a8260565dbd02eaaa376949de22a3..4f18b84c30aea7b5dfadd556ebfb4fa16a1915f0 100644
--- a/base/i18n/time_formatting.cc
+++ b/base/i18n/time_formatting.cc
@@ -157,8 +157,8 @@ string16 TimeDurationFormat(const TimeDelta& time,
const DurationFormatWidth width) {
UErrorCode status = U_ZERO_ERROR;
const int total_minutes = static_cast<int>(time.InSecondsF() / 60 + 0.5);
- int hours = total_minutes / 60;
- int minutes = total_minutes % 60;
+ const int hours = total_minutes / 60;
+ const int minutes = total_minutes % 60;
UMeasureFormatWidth u_width = DurationWidthToMeasureWidth(width);
const icu::Measure measures[] = {
@@ -171,6 +171,26 @@ string16 TimeDurationFormat(const TimeDelta& time,
return base::string16(formatted.getBuffer(), formatted.length());
}
+string16 TimeDurationFormatWithSeconds(const TimeDelta& time,
+ const DurationFormatWidth width) {
+ UErrorCode status = U_ZERO_ERROR;
+ const int64_t total_seconds = static_cast<int>(time.InSecondsF() + 0.5);
+ const int hours = total_seconds / 3600;
+ const int minutes = (total_seconds - hours * 3600) / 60;
+ const int seconds = total_seconds % 60;
+ UMeasureFormatWidth u_width = DurationWidthToMeasureWidth(width);
+
+ const icu::Measure measures[] = {
+ icu::Measure(hours, icu::MeasureUnit::createHour(status), status),
+ icu::Measure(minutes, icu::MeasureUnit::createMinute(status), status),
+ icu::Measure(seconds, icu::MeasureUnit::createSecond(status), status)};
+ icu::MeasureFormat measure_format(icu::Locale::getDefault(), u_width, status);
+ icu::UnicodeString formatted;
+ icu::FieldPosition ignore(icu::FieldPosition::DONT_CARE);
+ measure_format.formatMeasures(measures, 3, formatted, ignore, status);
+ return base::string16(formatted.getBuffer(), formatted.length());
+}
+
HourClockType GetHourClockType() {
// TODO(satorux,jshin): Rework this with ures_getByKeyWithFallback()
// once it becomes public. The short time format can be found at

Powered by Google App Engine
This is Rietveld 408576698