Add process start time and CPU time columns to task manager

base/i18n/time_formatting.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Basic time formatting methods.  These methods use the current locale
 // formatting for displaying the time.
 
 #ifndef BASE_I18N_TIME_FORMATTING_H_
 #define BASE_I18N_TIME_FORMATTING_H_
 
@@ skipping 59 matching lines @@
 // Formats a time in a friendly sentence format, e.g.
 // "Monday, March 6, 2008 2:44:30 PM".
 BASE_I18N_EXPORT string16 TimeFormatFriendlyDateAndTime(const Time& time);
 
 // Formats a time in a friendly sentence format, e.g.
 // "Monday, March 6, 2008".
 BASE_I18N_EXPORT string16 TimeFormatFriendlyDate(const Time& time);
 
 // Formats a time duration of hours and minutes into various formats, e.g.,
 // "3:07" or "3 hours, 7 minutes".  See DurationFormatWidth for details.
+//
+// Please don't use width = DURATION_WIDTH_NUMERIC when the time duration
+// can possibly be larger than 24h, as the hour value will be cut below 24
+// after formatting.
+// TODO (chengx) fix function output when width = DURATION_WIDTH_NUMERIC

[dcheng, 2016/12/21 20:45:37]

Nit: TODO(chengx): fix function output...

is the proper formatting.

[chengx, 2016/12/21 22:05:54]

Done.

+// (http://crbug.com/675791)

[brucedawson, 2016/12/21 02:13:40]

Maybe skip these comments.

[chengx, 2016/12/21 22:05:54]

I had a quick look on the fix, which turns out to be not that easy. Since it
will take some time for the fix, I will leave the comments here to avoid further
misuse on these functions.

 BASE_I18N_EXPORT string16 TimeDurationFormat(const TimeDelta& time,
                                              const DurationFormatWidth width);
 
+// Formats a time duration of hours, minutes and seconds into various formats,
+// e.g., "3:07:30" or "3 hours, 7 minutes, 30 seconds". See DurationFormatWidth
+// for details.
+//
+// Please don't use width = DURATION_WIDTH_NUMERIC when the time duration
+// can possibly be larger than 24h, as the hour value will be cut below 24
+// after formatting.
+// TODO (chengx) fix function output when width = DURATION_WIDTH_NUMERIC
+// (http://crbug.com/675791)
+BASE_I18N_EXPORT string16
+TimeDurationFormatWithSeconds(const TimeDelta& time,

[dcheng, 2016/12/21 20:45:37]

Note that base::Time, base::TimeDelta, base::TimeTicks are designed to be passed
by value. We should do that here.

[chengx, 2016/12/21 22:05:54]

Alright, I changed to pass-by-value for the two TimeDuration functions. For
other functions, I will keep them for now or I will use another CL.

+                              const DurationFormatWidth width);
+
 // Gets the hour clock type of the current locale. e.g.
 // k12HourClock (en-US).
 // k24HourClock (en-GB).
 BASE_I18N_EXPORT HourClockType GetHourClockType();
 
 }  // namespace base
 
 #endif  // BASE_I18N_TIME_FORMATTING_H_