Add process start time and CPU time columns to task manager

chrome/browser/task_manager/task_manager_observer.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_OBSERVER_H_
 #define CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_OBSERVER_H_
 
 #include <stdint.h>
 
 #include <vector>
 
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "build/build_config.h"
 
 namespace task_manager {
 
 class TaskManagerInterface;
 
 using TaskId = int64_t;
 using TaskIdList = std::vector<TaskId>;
 
 // Defines a list of types of resources that an observer needs to be refreshed
 // on every task manager refresh cycle.
 enum RefreshType {
   REFRESH_TYPE_NONE              = 0,
   REFRESH_TYPE_CPU               = 1,
-  REFRESH_TYPE_PHYSICAL_MEMORY   = 1 << 1,
-  REFRESH_TYPE_MEMORY_DETAILS    = 1 << 2,
-  REFRESH_TYPE_GPU_MEMORY        = 1 << 3,
-  REFRESH_TYPE_V8_MEMORY         = 1 << 4,
-  REFRESH_TYPE_SQLITE_MEMORY     = 1 << 5,
-  REFRESH_TYPE_WEBCACHE_STATS    = 1 << 6,
-  REFRESH_TYPE_NETWORK_USAGE     = 1 << 7,
-  REFRESH_TYPE_NACL              = 1 << 8,
-  REFRESH_TYPE_IDLE_WAKEUPS      = 1 << 9,
-  REFRESH_TYPE_HANDLES           = 1 << 10,
+  REFRESH_TYPE_START_TIME        = 1 << 1,

[brucedawson, 2016/12/19 21:51:06]

Why did you insert these at the beginning? Wouldn't it be simpler and easier to
review if you added them at the end, to avoid renumbering everything?

[chengx, 2016/12/20 00:51:12]

Done.

+  REFRESH_TYPE_CPU_TIME          = 1 << 2,
+  REFRESH_TYPE_PHYSICAL_MEMORY   = 1 << 3,
+  REFRESH_TYPE_MEMORY_DETAILS    = 1 << 4,
+  REFRESH_TYPE_GPU_MEMORY        = 1 << 5,
+  REFRESH_TYPE_V8_MEMORY         = 1 << 6,
+  REFRESH_TYPE_SQLITE_MEMORY     = 1 << 7,
+  REFRESH_TYPE_WEBCACHE_STATS    = 1 << 8,
+  REFRESH_TYPE_NETWORK_USAGE     = 1 << 9,
+  REFRESH_TYPE_NACL              = 1 << 10,
+  REFRESH_TYPE_IDLE_WAKEUPS      = 1 << 11,
+  REFRESH_TYPE_HANDLES           = 1 << 12,
 
   // Whether an observer is interested in knowing if a process is foregrounded
   // or backgrounded.
-  REFRESH_TYPE_PRIORITY          = 1 << 11,
+  REFRESH_TYPE_PRIORITY          = 1 << 13,
 
 #if defined(OS_LINUX)
   // For observers interested in getting the number of open file descriptors of
   // processes.
-  REFRESH_TYPE_FD_COUNT          = 1 << 12,
+  REFRESH_TYPE_FD_COUNT          = 1 << 14,
 #endif  // defined(OS_LINUX)
 
   REFRESH_TYPE_MEMORY            = REFRESH_TYPE_PHYSICAL_MEMORY |
                                    REFRESH_TYPE_MEMORY_DETAILS,
 };
 
 // Defines the interface for observers of the task manager.
 class TaskManagerObserver {
  public:
   static bool IsResourceRefreshEnabled(RefreshType refresh_type,
@@ skipping 82 matching lines @@
   // calculated on each refresh.
   int64_t desired_resources_flags_;
 
   DISALLOW_COPY_AND_ASSIGN(TaskManagerObserver);
 };
 
 }  // namespace task_manager
 
 
 #endif  // CHROME_BROWSER_TASK_MANAGER_TASK_MANAGER_OBSERVER_H_