Add process start time and CPU time columns to task manager

base/i18n/time_formatting_unittest.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/i18n/time_formatting.h"
 
 #include <memory>
 
 #include "base/i18n/rtl.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 247 matching lines @@
   string16 fa_narrow = WideToUTF16(
       L"\x6f1\x6f5\x20\x633\x627\x639\x62a\x20\x6f4\x6f2\x20\x62f\x642\x6cc"
       L"\x642\x647");
   string16 fa_numeric = WideToUTF16(L"\x6f1\x6f5\x3a\x6f4\x6f2");
   EXPECT_EQ(fa_wide, TimeDurationFormat(delta, DURATION_WIDTH_WIDE));
   EXPECT_EQ(fa_short, TimeDurationFormat(delta, DURATION_WIDTH_SHORT));
   EXPECT_EQ(fa_narrow, TimeDurationFormat(delta, DURATION_WIDTH_NARROW));
   EXPECT_EQ(fa_numeric, TimeDurationFormat(delta, DURATION_WIDTH_NUMERIC));
 }
 
+TEST(TimeFormattingTest, TimeDurationWFormatWithSecondPrecison) {
+  test::ScopedRestoreICUDefaultLocale restore_locale;
+  TimeDelta delta = TimeDelta::FromSeconds(15 * 3600 + 42 * 60 + 30);
+
+  // US English.
+  i18n::SetICUDefaultLocale("en_US");
+  EXPECT_EQ(ASCIIToUTF16("15 hours, 42 minutes, 30 seconds"),

[brucedawson, 2016/12/19 21:51:05]

Should add some tests for times like 15 hours, 0 minutes, 10 seconds, and 15
hours, 10 minutes, 0 seconds. Those cases sometimes trigger errors.

[chengx, 2016/12/20 00:51:12]

Done.

+            TimeDurationWFormatWithSecondPrecison(delta, DURATION_WIDTH_WIDE));
+  EXPECT_EQ(ASCIIToUTF16("15 hr, 42 min, 30 sec"),
+            TimeDurationWFormatWithSecondPrecison(delta, DURATION_WIDTH_SHORT));
+  EXPECT_EQ(ASCIIToUTF16("15h 42m 30s"), TimeDurationWFormatWithSecondPrecison(
+                                             delta, DURATION_WIDTH_NARROW));
+  EXPECT_EQ(ASCIIToUTF16("15:42:30"), TimeDurationWFormatWithSecondPrecison(

[stanisc, 2016/12/19 22:44:10]

Should add tests for times with greater than 24 or greater than 100 hours.

[chengx, 2016/12/20 00:51:12]

Actually we have a bug in //base that when the hour is greater than 24 and the
format is DURATION_WIDTH_NARROW (which is the compact), the hour will be
converted to its value mod by 24. I will fix it in another CL.

+                                          delta, DURATION_WIDTH_NUMERIC));
+}
+
 }  // namespace
 }  // namespace base