Add process start time and CPU time columns to task manager

base/i18n/time_formatting.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/i18n/time_formatting.h"
 
 #include <stddef.h>
 
 #include <memory>
 
@@ skipping 153 matching lines @@
   const icu::Measure measures[] = {
       icu::Measure(hours, icu::MeasureUnit::createHour(status), status),
       icu::Measure(minutes, icu::MeasureUnit::createMinute(status), status)};
   icu::MeasureFormat measure_format(icu::Locale::getDefault(), u_width, status);
   icu::UnicodeString formatted;
   icu::FieldPosition ignore(icu::FieldPosition::DONT_CARE);
   measure_format.formatMeasures(measures, 2, formatted, ignore, status);
   return base::string16(formatted.getBuffer(), formatted.length());
 }
 
+string16 TimeDurationWFormatWithSecondPrecison(
+    const TimeDelta& time,
+    const DurationFormatWidth width) {
+  UErrorCode status = U_ZERO_ERROR;
+  const int64_t total_seconds = time.InSeconds();

[brucedawson, 2016/12/19 21:51:05]

Consider rounding to nearest as in TimeDurationFormat. Doesn't make much
difference of course, but seems consistent.

[chengx, 2016/12/20 00:51:12]

Done.

+  int hours = total_seconds / 3600;

[brucedawson, 2016/12/19 21:51:05]

Why no 'const' here? It seems inconsistent with total_seconds. I am a fan of
marking all variables with const if they can be, although not all share my
enthusiasm.

And yes, I notice that TimeDurationFormat also has this inconsistency. Is it
required by icu somehow?

[chengx, 2016/12/20 00:51:12]

In icu::Measure, actually its first parameter is const, so I will just change
all of them to const.

+  int minutes = (total_seconds - hours * 3600) / 60;
+  int seconds = total_seconds % 60;
+  UMeasureFormatWidth u_width = DurationWidthToMeasureWidth(width);
+
+  const icu::Measure measures[] = {
+      icu::Measure(hours, icu::MeasureUnit::createHour(status), status),
+      icu::Measure(minutes, icu::MeasureUnit::createMinute(status), status),
+      icu::Measure(seconds, icu::MeasureUnit::createSecond(status), status)};
+  icu::MeasureFormat measure_format(icu::Locale::getDefault(), u_width, status);
+  icu::UnicodeString formatted;
+  icu::FieldPosition ignore(icu::FieldPosition::DONT_CARE);
+  measure_format.formatMeasures(measures, 3, formatted, ignore, status);
+  return base::string16(formatted.getBuffer(), formatted.length());
+}
+
 HourClockType GetHourClockType() {
   // TODO(satorux,jshin): Rework this with ures_getByKeyWithFallback()
   // once it becomes public. The short time format can be found at
   // "calendar/gregorian/DateTimePatterns/3" in the resources.
   std::unique_ptr<icu::SimpleDateFormat> formatter(
       static_cast<icu::SimpleDateFormat*>(
           icu::DateFormat::createTimeInstance(icu::DateFormat::kShort)));
   // Retrieve the short time format.
   icu::UnicodeString pattern_unicode;
   formatter->toPattern(pattern_unicode);
@@ skipping 21 matching lines @@
   // See http://userguide.icu-project.org/formatparse/datetime for details
   // about the date/time format syntax.
   if (pattern_unicode.indexOf('a') == -1) {
     return k24HourClock;
   } else {
     return k12HourClock;
   }
 }
 
 }  // namespace base