chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java - Issue 2573173002: 📰 Split TreeNode#init into SetParent and SetChildren

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java

Issue 2573173002: 📰 Split TreeNode#init into SetParent and SetChildren (Closed)

Patch Set: revert getChildren() change Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java ('k') | chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/InnerNodeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java

index 75997a493b5d2cba0d22cfc559b89de60a92aaee..6816a1a46eec15e2304263945bf255a3d6c14dbb 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/TreeNode.java

@@ -4,8 +4,6 @@

package org.chromium.chrome.browser.ntp.cards;

-import android.support.annotation.CallSuper;

import org.chromium.chrome.browser.ntp.snippets.SnippetArticle;

/**

@@ -17,8 +15,7 @@

* node has been added to the tree, i.e. when it is in the list of its parent's children.

* The node may notify its parent about changes that happen during initialization.

- @CallSuper

- void init();

+ void setParent(NodeParent parent);

/**

* Returns the number of items under this subtree. This method may be called