chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java - Issue 2573173002: 📰 Split TreeNode#init into SetParent and SetChildren

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

Issue 2573173002: 📰 Split TreeNode#init into SetParent and SetChildren (Closed)

Patch Set: revert getChildren() change Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SectionList.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SpacingItem.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

index 1ad2c93d905e8c78e7b3ba35a7f4b3f2c966f21a..a8c1ca1d5ac780a18312cbf99f143ace0fd33b3d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SignInPromo.java

@@ -42,8 +42,7 @@

@Nullable

private final SigninObserver mObserver;

- public SignInPromo(NodeParent parent, NewTabPageManager newTabPageManager) {

- super(parent);

+ public SignInPromo(NewTabPageManager newTabPageManager) {

mDismissed = ChromePreferenceManager.getInstance(ContextUtils.getApplicationContext())

.getNewTabPageSigninPromoDismissed();

@@ -54,12 +53,7 @@ public SignInPromo(NodeParent parent, NewTabPageManager newTabPageManager) {

mObserver = new SigninObserver(signinManager);

newTabPageManager.addDestructionObserver(mObserver);

}

- }

- @Override

- public void init() {

- super.init();

- SigninManager signinManager = SigninManager.get(ContextUtils.getApplicationContext());

setVisible(signinManager.isSignInAllowed() && !signinManager.isSignedInOnNative());

}