chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java - Issue 2573173002: 📰 Split TreeNode#init into SetParent and SetChildren

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

Issue 2573173002: 📰 Split TreeNode#init into SetParent and SetChildren (Closed)

Patch Set: revert getChildren() change Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/InnerNode.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

index a2282a050c143b86803ca35793c5e8eafb154a85..ade8c74612e2d688ae4b362dd80a5f92ab8a3170 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Leaf.java

@@ -11,7 +11,7 @@

* If the leaf is not to be a permanent member of the tree, see {@link OptionalLeaf} for an

* implementation that will take care of hiding or showing the item.

-public abstract class Leaf implements TreeNode {

+public abstract class Leaf extends ChildNode {

@Override

public int getItemCount() {

return 1;

@@ -42,9 +42,6 @@ public int getDismissSiblingPosDelta(int position) {

return 0;

}

- @Override

- public void init() {}

/**

* Display the data for this item.

* @param holder The view holder that should be updated.