Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1130)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java

Issue 2573173002: 📰 Split TreeNode#init into SetParent and SetChildren (Closed)
Patch Set: revert getChildren() change Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java
index 87151a0386abaebefc7fdeaa077644c809740c31..0aaf26ff2bb1cf7c080b9fa7b9185152416ba09b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ChildNode.java
@@ -4,31 +4,34 @@
package org.chromium.chrome.browser.ntp.cards;
+import android.support.annotation.CallSuper;
+
/**
* A node in the tree that has a parent and can notify it about changes.
*
* This class mostly serves as a convenience base class for implementations of {@link TreeNode}.
*/
public abstract class ChildNode implements TreeNode {
- private final NodeParent mParent;
+ private NodeParent mParent;
- protected ChildNode(NodeParent parent) {
+ @Override
+ @CallSuper
+ public void setParent(NodeParent parent) {
+ assert mParent == null;
+ assert parent != null;
mParent = parent;
}
- @Override
- public void init() {}
-
protected void notifyItemRangeChanged(int index, int count) {
- mParent.onItemRangeChanged(this, index, count);
+ if (mParent != null) mParent.onItemRangeChanged(this, index, count);
}
protected void notifyItemRangeInserted(int index, int count) {
- mParent.onItemRangeInserted(this, index, count);
+ if (mParent != null) mParent.onItemRangeInserted(this, index, count);
}
protected void notifyItemRangeRemoved(int index, int count) {
- mParent.onItemRangeRemoved(this, index, count);
+ if (mParent != null) mParent.onItemRangeRemoved(this, index, count);
}
protected void notifyItemChanged(int index) {

Powered by Google App Engine
This is Rietveld 408576698