Handle non-regular files in recursive delete

Handle non-regular files in recursive delete

Fix is similar to the fix for directory listing from last week.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/4b9087f9f5a98814142a5a08d441236cc5a0bae5

[zra, 2016-12-14 17:34:33]

zra@google.com changed reviewers:
+ floitsch@google.com, rmacnak@google.com

[rmacnak, 2016-12-14 18:44:02]

lgtm

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_andro...
File runtime/bin/directory_android.cc (right):

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_andro...
runtime/bin/directory_android.cc:320: } else if (S_ISREG(entry_info.st_mode) ||
S_ISCHR(entry_info.st_mode) ||
Keep S_ISLNK

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_linux.cc
File runtime/bin/directory_linux.cc (right):

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_linux...
runtime/bin/directory_linux.cc:329: } else if (S_ISREG(entry_info.st_mode) ||
S_ISCHR(entry_info.st_mode) ||
Keep S_ISLNK

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_macos.cc
File runtime/bin/directory_macos.cc (right):

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_macos...
runtime/bin/directory_macos.cc:320: } else if (S_ISREG(entry_info.st_mode) ||
S_ISCHR(entry_info.st_mode) ||
Keep S_ISLNK

[zra, 2016-12-14 20:48:07]

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_andro...
File runtime/bin/directory_android.cc (right):

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_andro...
runtime/bin/directory_android.cc:320: } else if (S_ISREG(entry_info.st_mode) ||
S_ISCHR(entry_info.st_mode) ||
On 2016/12/14 18:44:02, rmacnak wrote:
> Keep S_ISLNK

Done.

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_linux.cc
File runtime/bin/directory_linux.cc (right):

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_linux...
runtime/bin/directory_linux.cc:329: } else if (S_ISREG(entry_info.st_mode) ||
S_ISCHR(entry_info.st_mode) ||
On 2016/12/14 18:44:02, rmacnak wrote:
> Keep S_ISLNK

Done.

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_macos.cc
File runtime/bin/directory_macos.cc (right):

https://codereview.chromium.org/2573143002/diff/1/runtime/bin/directory_macos...
runtime/bin/directory_macos.cc:320: } else if (S_ISREG(entry_info.st_mode) ||
S_ISCHR(entry_info.st_mode) ||
On 2016/12/14 18:44:02, rmacnak wrote:
> Keep S_ISLNK

Done.

[zra, 2016-12-14 20:55:03]

Description was changed from

==========
Handle non-regular files in recursive delete

Fix is similar to the fix for directory listing from last week.
==========

to

==========
Handle non-regular files in recursive delete

Fix is similar to the fix for directory listing from last week.

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4b9087f9f5a98814142a5a08d441236cc5a0bae5
==========

[zra, 2016-12-14 20:55:04]

Committed patchset #2 (id:20001) manually as
4b9087f9f5a98814142a5a08d441236cc5a0bae5 (presubmit successful).