third_party/WebKit/Source/web/tests/VisualViewportTest.cpp - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

index 75484716c77f289197f6cc2da31ba8c2eeefb1a8..15ec9d455aa7f6dfb41f7ec31aa17e8f16cf0619 100644

--- a/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

+++ b/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp

@@ -1865,9 +1865,10 @@ TEST_P(VisualViewportTest, SlowScrollAfterImplScroll) {

EXPECT_SIZE_EQ(FloatSize(300, 200), visualViewport.getScrollOffset());

// Send a scroll event on the main thread path.

- WebGestureEvent gsu;

+ WebGestureEvent gsu(WebInputEvent::GestureScrollUpdate,

+ WebInputEvent::NoModifiers,

+ WebInputEvent::TimeStampForTesting);

gsu.setFrameScale(1);

- gsu.type = WebInputEvent::GestureScrollUpdate;

gsu.sourceDevice = WebGestureDeviceTouchpad;

gsu.data.scrollUpdate.deltaX = -50;

gsu.data.scrollUpdate.deltaY = -60;