third_party/WebKit/Source/web/WebPagePopupImpl.cpp - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebPagePopupImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

index 34ad8d9dda5a1f3bb45fd428d4c8cb27c43f7ed5..7e1d2c3d94fe15ea2b7235f99dde0f3d274f82f8 100644

--- a/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

+++ b/third_party/WebKit/Source/web/WebPagePopupImpl.cpp

@@ -472,8 +472,8 @@ WebInputEventResult WebPagePopupImpl::handleGestureEvent(

if (m_closing || !m_page || !m_page->mainFrame() ||

!toLocalFrame(m_page->mainFrame())->view())

return WebInputEventResult::NotHandled;

- if ((event.type == WebInputEvent::GestureTap ||

- event.type == WebInputEvent::GestureTapDown) &&

+ if ((event.type() == WebInputEvent::GestureTap ||

+ event.type() == WebInputEvent::GestureTapDown) &&

!isViewportPointInWindow(event.x, event.y)) {

cancel();

return WebInputEventResult::NotHandled;