Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.cpp

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)
Patch Set: Fix nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ExternalPopupMenu.cpp
diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
index 172ecd2803b1f4fcc5bdd3b3d27347dfae328472..8a7af6f859a95908508f5081360c94947af923ba 100644
--- a/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.cpp
@@ -113,10 +113,10 @@ void ExternalPopupMenu::show() {
return;
#if OS(MACOSX)
const WebInputEvent* currentEvent = WebViewImpl::currentInputEvent();
- if (currentEvent && currentEvent->type == WebInputEvent::MouseDown) {
+ if (currentEvent && currentEvent->type() == WebInputEvent::MouseDown) {
m_syntheticEvent = WTF::wrapUnique(new WebMouseEvent);
*m_syntheticEvent = *static_cast<const WebMouseEvent*>(currentEvent);
- m_syntheticEvent->type = WebInputEvent::MouseUp;
+ m_syntheticEvent->setType(WebInputEvent::MouseUp);
m_dispatchEventTimer.startOneShot(0, BLINK_FROM_HERE);
// FIXME: show() is asynchronous. If preparing a popup is slow and a
// user released the mouse button before showing the popup, mouseup and
« no previous file with comments | « third_party/WebKit/Source/web/DevToolsEmulator.cpp ('k') | third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698