Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)
Patch Set: Fix nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index 9abf01c8d01df2660217c29e6dfc24c503fac500..72652c8a0cf39b176e57e96a29d67f716540e586 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -601,9 +601,9 @@ bool RendererSchedulerImpl::ShouldPrioritizeInputEvent(
const blink::WebInputEvent& web_input_event) {
// We regard MouseMove events with the left mouse button down as a signal
// that the user is doing something requiring a smooth frame rate.
- if ((web_input_event.type == blink::WebInputEvent::MouseDown ||
- web_input_event.type == blink::WebInputEvent::MouseMove) &&
- (web_input_event.modifiers & blink::WebInputEvent::LeftButtonDown)) {
+ if ((web_input_event.type() == blink::WebInputEvent::MouseDown ||
+ web_input_event.type() == blink::WebInputEvent::MouseMove) &&
+ (web_input_event.modifiers() & blink::WebInputEvent::LeftButtonDown)) {
return true;
}
// Ignore all other mouse events because they probably don't signal user
@@ -611,8 +611,8 @@ bool RendererSchedulerImpl::ShouldPrioritizeInputEvent(
// for mouse wheel events, hence we regard them as user input.
// Ignore keyboard events because it doesn't really make sense to enter
// compositor priority for them.
- if (blink::WebInputEvent::isMouseEventType(web_input_event.type) ||
- blink::WebInputEvent::isKeyboardEventType(web_input_event.type)) {
+ if (blink::WebInputEvent::isMouseEventType(web_input_event.type()) ||
+ blink::WebInputEvent::isKeyboardEventType(web_input_event.type())) {
return false;
}
return true;
@@ -626,7 +626,7 @@ void RendererSchedulerImpl::DidHandleInputEventOnCompositorThread(
if (!ShouldPrioritizeInputEvent(web_input_event))
return;
- UpdateForInputEventOnCompositorThread(web_input_event.type, event_state);
+ UpdateForInputEventOnCompositorThread(web_input_event.type(), event_state);
}
void RendererSchedulerImpl::DidAnimateForInputOnCompositorThread() {

Powered by Google App Engine
This is Rietveld 408576698