extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/app_window/app_web_contents_helper.cc ('k') | extensions/browser/guest_view/web_view/web_view_guest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

diff --git a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

index 049af1623953e9160fd0dae87b20890328141812..6e595628015e1eb82b8ee7bb4ecb473a6445e4b7 100644

--- a/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

+++ b/extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc

@@ -245,9 +245,9 @@ bool MimeHandlerViewGuest::HandleContextMenu(

bool MimeHandlerViewGuest::PreHandleGestureEvent(

WebContents* source,

const blink::WebGestureEvent& event) {

- if (event.type == blink::WebGestureEvent::GesturePinchBegin ||

- event.type == blink::WebGestureEvent::GesturePinchUpdate ||

- event.type == blink::WebGestureEvent::GesturePinchEnd) {

+ if (event.type() == blink::WebGestureEvent::GesturePinchBegin ||

+ event.type() == blink::WebGestureEvent::GesturePinchUpdate ||

+ event.type() == blink::WebGestureEvent::GesturePinchEnd) {

// If we're an embedded plugin we drop pinch-gestures to avoid zooming the

// guest.

return !is_full_page_plugin();