content/browser/renderer_host/input/web_input_event_util_unittest.cc - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_util_unittest.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/web_input_event_builders_mac_unittest.mm ('k') | content/browser/renderer_host/native_web_keyboard_event_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/web_input_event_util_unittest.cc

diff --git a/content/browser/renderer_host/input/web_input_event_util_unittest.cc b/content/browser/renderer_host/input/web_input_event_util_unittest.cc

index 6444f9e2a3123f0ca14f9f4a0465fd924a0905dd..cbc40821d5beeec6bd52453423eb0643a341d206 100644

--- a/content/browser/renderer_host/input/web_input_event_util_unittest.cc

+++ b/content/browser/renderer_host/input/web_input_event_util_unittest.cc

@@ -111,10 +111,10 @@ TEST(WebInputEventUtilTest, ScrollUpdateConversion) {

blink::WebGestureEvent web_event =

ui::CreateWebGestureEventFromGestureEventData(event);

- EXPECT_EQ(WebInputEvent::GestureScrollUpdate, web_event.type);

- EXPECT_EQ(0, web_event.modifiers);

+ EXPECT_EQ(WebInputEvent::GestureScrollUpdate, web_event.type());

+ EXPECT_EQ(0, web_event.modifiers());

EXPECT_EQ((timestamp - base::TimeTicks()).InSecondsF(),

- web_event.timeStampSeconds);

+ web_event.timeStampSeconds());

EXPECT_EQ(gfx::ToFlooredInt(pos.x()), web_event.x);

EXPECT_EQ(gfx::ToFlooredInt(pos.y()), web_event.y);

EXPECT_EQ(gfx::ToFlooredInt(raw_pos.x()), web_event.globalX);