content/browser/renderer_host/input/web_input_event_builders_android.cc - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/web_input_event_builders_android.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/touchscreen_tap_suppression_controller.cc ('k') | content/browser/renderer_host/input/web_input_event_builders_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/web_input_event_builders_android.cc

diff --git a/content/browser/renderer_host/input/web_input_event_builders_android.cc b/content/browser/renderer_host/input/web_input_event_builders_android.cc

index afffca048275515d0f8312ab5e85f9b85d905948..9bdd73f84681228728bbec6930621f7bde9c6365 100644

--- a/content/browser/renderer_host/input/web_input_event_builders_android.cc

+++ b/content/browser/renderer_host/input/web_input_event_builders_android.cc

@@ -83,14 +83,16 @@ WebKeyboardEvent WebKeyboardEventBuilder::Build(

int unicode_character,

bool is_system_key) {

DCHECK(WebInputEvent::isKeyboardEventType(type));

- WebKeyboardEvent result(type, modifiers, time_sec);

ui::DomCode dom_code = ui::DomCode::NONE;

if (scancode)

dom_code = ui::KeycodeConverter::NativeKeycodeToDomCode(scancode);

+ WebKeyboardEvent result(

+ type, modifiers | ui::DomCodeToWebInputEventModifiers(dom_code),

+ time_sec);

result.windowsKeyCode = ui::LocatedToNonLocatedKeyboardCode(

ui::KeyboardCodeFromAndroidKeyCode(keycode));

- result.modifiers |= ui::DomCodeToWebInputEventModifiers(dom_code);

result.nativeKeyCode = keycode;

result.domCode = static_cast<int>(dom_code);

result.domKey = GetDomKeyFromEvent(env, android_key_event, keycode, modifiers,