content/browser/renderer_host/input/synthetic_gesture_target_mac.mm - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/synthetic_gesture_target_mac.mm

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/synthetic_gesture_target_base.cc ('k') | content/browser/renderer_host/input/synthetic_pointer_action_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/synthetic_gesture_target_mac.mm

diff --git a/content/browser/renderer_host/input/synthetic_gesture_target_mac.mm b/content/browser/renderer_host/input/synthetic_gesture_target_mac.mm

index 92d3617594e49f5c9b6a392d3dde935c02548159..d10bcb69154d389318b6f67ba231dba728f5f1cd 100644

--- a/content/browser/renderer_host/input/synthetic_gesture_target_mac.mm

+++ b/content/browser/renderer_host/input/synthetic_gesture_target_mac.mm

@@ -77,7 +77,7 @@ SyntheticGestureTargetMac::SyntheticGestureTargetMac(

void SyntheticGestureTargetMac::DispatchInputEventToPlatform(

const WebInputEvent& event) {

- if (WebInputEvent::isGestureEventType(event.type)) {

+ if (WebInputEvent::isGestureEventType(event.type())) {

// Create an autorelease pool so that we clean up any synthetic events we

// generate.

base::mac::ScopedNSAutoreleasePool pool;

@@ -85,7 +85,7 @@ void SyntheticGestureTargetMac::DispatchInputEventToPlatform(

const WebGestureEvent* gesture_event =

static_cast<const WebGestureEvent*>(&event);

- switch (event.type) {

+ switch (event.type()) {

case WebInputEvent::GesturePinchBegin: {

id event = [SyntheticPinchEvent

eventWithMagnification:0.0f