content/browser/renderer_host/input/mock_input_ack_handler.cc - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/mock_input_ack_handler.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/input_router_impl_unittest.cc ('k') | content/browser/renderer_host/input/motion_event_web.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/mock_input_ack_handler.cc

diff --git a/content/browser/renderer_host/input/mock_input_ack_handler.cc b/content/browser/renderer_host/input/mock_input_ack_handler.cc

index 32993722774206431bb56f79d3972b3fb2bb098a..f7ab19e01133e1625e667513789f7d46480be262 100644

--- a/content/browser/renderer_host/input/mock_input_ack_handler.cc

+++ b/content/browser/renderer_host/input/mock_input_ack_handler.cc

@@ -32,7 +32,7 @@ void MockInputAckHandler::OnKeyboardEventAck(

InputEventAckState ack_result) {

VLOG(1) << __FUNCTION__ << " called!";

acked_key_event_.reset(new NativeWebKeyboardEvent(event.event));

- RecordAckCalled(event.event.type, ack_result);

+ RecordAckCalled(event.event.type(), ack_result);

}

void MockInputAckHandler::OnMouseEventAck(

@@ -40,7 +40,7 @@ void MockInputAckHandler::OnMouseEventAck(

InputEventAckState ack_result) {

VLOG(1) << __FUNCTION__ << " called!";

acked_mouse_event_ = event.event;

- RecordAckCalled(event.event.type, ack_result);

+ RecordAckCalled(event.event.type(), ack_result);

}

void MockInputAckHandler::OnWheelEventAck(

@@ -48,7 +48,7 @@ void MockInputAckHandler::OnWheelEventAck(

InputEventAckState ack_result) {

VLOG(1) << __FUNCTION__ << " called!";

acked_wheel_event_ = event.event;

- RecordAckCalled(event.event.type, ack_result);

+ RecordAckCalled(event.event.type(), ack_result);

}

void MockInputAckHandler::OnTouchEventAck(

@@ -56,7 +56,7 @@ void MockInputAckHandler::OnTouchEventAck(

InputEventAckState ack_result) {

VLOG(1) << __FUNCTION__ << " called!";

acked_touch_event_ = event;

- RecordAckCalled(event.event.type, ack_result);

+ RecordAckCalled(event.event.type(), ack_result);

if (touch_followup_event_)

input_router_->SendTouchEvent(*touch_followup_event_);

if (gesture_followup_event_)

@@ -68,7 +68,7 @@ void MockInputAckHandler::OnGestureEventAck(

InputEventAckState ack_result) {

VLOG(1) << __FUNCTION__ << " called!";

acked_gesture_event_ = event.event;

- RecordAckCalled(event.event.type, ack_result);

+ RecordAckCalled(event.event.type(), ack_result);

}

void MockInputAckHandler::OnUnexpectedEventAck(UnexpectedEventAckType type) {