content/browser/browser_plugin/browser_plugin_embedder.cc - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_embedder.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/browser_plugin/browser_plugin_embedder.cc

diff --git a/content/browser/browser_plugin/browser_plugin_embedder.cc b/content/browser/browser_plugin/browser_plugin_embedder.cc

index 76e2446effbc6c69c564852bd361793f1105d7b8..c558b8f9b1f2c44df5f95ffa57e5306a8cad974b 100644

--- a/content/browser/browser_plugin/browser_plugin_embedder.cc

+++ b/content/browser/browser_plugin/browser_plugin_embedder.cc

@@ -174,7 +174,7 @@ void BrowserPluginEmbedder::OnAttach(

bool BrowserPluginEmbedder::HandleKeyboardEvent(

const NativeWebKeyboardEvent& event) {

if ((event.windowsKeyCode != ui::VKEY_ESCAPE) ||

- (event.modifiers & blink::WebInputEvent::InputModifiers)) {

+ (event.modifiers() & blink::WebInputEvent::InputModifiers)) {

return false;

}