Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2717)

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)
Patch Set: Fix nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/frame/browser_view.cc
diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc
index 489d9b147d471704af9c65a32e0ba2561b7d123b..73ece4834dedcb423448918b5f124b873331e537 100644
--- a/chrome/browser/ui/views/frame/browser_view.cc
+++ b/chrome/browser/ui/views/frame/browser_view.cc
@@ -1308,8 +1308,8 @@ bool BrowserView::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
bool* is_keyboard_shortcut) {
*is_keyboard_shortcut = false;
- if ((event.type != blink::WebInputEvent::RawKeyDown) &&
- (event.type != blink::WebInputEvent::KeyUp)) {
+ if ((event.type() != blink::WebInputEvent::RawKeyDown) &&
+ (event.type() != blink::WebInputEvent::KeyUp)) {
return false;
}
@@ -1343,7 +1343,7 @@ bool BrowserView::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
#if defined(OS_CHROMEOS)
if (chrome::IsAcceleratorDeprecated(accelerator)) {
- if (event.type == blink::WebInputEvent::RawKeyDown)
+ if (event.type() == blink::WebInputEvent::RawKeyDown)
*is_keyboard_shortcut = true;
return false;
}
@@ -1377,7 +1377,7 @@ bool BrowserView::PreHandleKeyboardEvent(const NativeWebKeyboardEvent& event,
if (id != -1) {
// |accelerator| is a non-reserved browser shortcut (e.g. Ctrl+f).
- if (event.type == blink::WebInputEvent::RawKeyDown)
+ if (event.type() == blink::WebInputEvent::RawKeyDown)
*is_keyboard_shortcut = true;
} else if (processed) {
// |accelerator| is a non-browser shortcut (e.g. F4-F10 on Ash). Report
« no previous file with comments | « chrome/browser/ui/exclusive_access/exclusive_access_manager.cc ('k') | components/guest_view/browser/guest_view_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698