chrome/browser/ui/cocoa/extensions/extension_view_mac.mm - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Fix nits Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm b/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

index 1b8679401dbff2d575cd1f518cf0a8b9f17f1d48..c6624b212d0ac46b0e66f591e5426fc3ecde0851 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_view_mac.mm

@@ -69,7 +69,7 @@ void ExtensionViewMac::HandleKeyboardEvent(

content::WebContents* source,

const content::NativeWebKeyboardEvent& event) {

if (event.skip_in_browser ||

- event.type == content::NativeWebKeyboardEvent::Char ||

+ event.type() == content::NativeWebKeyboardEvent::Char ||

extension_host_->extension_host_type() !=

extensions::VIEW_TYPE_EXTENSION_POPUP)

return;