Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3159)

Unified Diff: chrome/browser/chromeos/login/ui/webui_login_view.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)
Patch Set: Fix nits Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/ui/webui_login_view.cc
diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.cc b/chrome/browser/chromeos/login/ui/webui_login_view.cc
index 5afb639e8648e33bb94ba20563f81828d002d390..2090525a3abdf73c4d33b9069509bdac83cbd3b9 100644
--- a/chrome/browser/chromeos/login/ui/webui_login_view.cc
+++ b/chrome/browser/chromeos/login/ui/webui_login_view.cc
@@ -529,7 +529,7 @@ void WebUILoginView::HandleKeyboardEvent(content::WebContents* source,
// Make sure error bubble is cleared on keyboard event. This is needed
// when the focus is inside an iframe. Only clear on KeyDown to prevent hiding
// an immediate authentication error (See crbug.com/103643).
- if (event.type == blink::WebInputEvent::KeyDown) {
+ if (event.type() == blink::WebInputEvent::KeyDown) {
content::WebUI* web_ui = GetWebUI();
if (web_ui)
web_ui->CallJavascriptFunctionUnsafe("cr.ui.Oobe.clearErrors");
@@ -621,9 +621,9 @@ bool WebUILoginView::PreHandleGestureEvent(
content::WebContents* source,
const blink::WebGestureEvent& event) {
// Disable pinch zooming.
- return event.type == blink::WebGestureEvent::GesturePinchBegin ||
- event.type == blink::WebGestureEvent::GesturePinchUpdate ||
- event.type == blink::WebGestureEvent::GesturePinchEnd;
+ return event.type() == blink::WebGestureEvent::GesturePinchBegin ||
+ event.type() == blink::WebGestureEvent::GesturePinchUpdate ||
+ event.type() == blink::WebGestureEvent::GesturePinchEnd;
}
void WebUILoginView::OnLoginPromptVisible() {
« no previous file with comments | « chrome/browser/chromeos/input_method/textinput_test_helper.cc ('k') | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698