Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/InspectorOverlay.cpp
diff --git a/third_party/WebKit/Source/web/InspectorOverlay.cpp b/third_party/WebKit/Source/web/InspectorOverlay.cpp
index d566b1120887d49a2029f0d4dfa0654512d17936..98e55d79f812fe210a8f280340773ae33670108f 100644
--- a/third_party/WebKit/Source/web/InspectorOverlay.cpp
+++ b/third_party/WebKit/Source/web/InspectorOverlay.cpp
@@ -232,8 +232,8 @@ bool InspectorOverlay::handleInputEvent(const WebInputEvent& inputEvent) {
if (isEmpty())
return false;
- if (WebInputEvent::isGestureEventType(inputEvent.type) &&
- inputEvent.type == WebInputEvent::GestureTap) {
+ if (WebInputEvent::isGestureEventType(inputEvent.type()) &&
+ inputEvent.type() == WebInputEvent::GestureTap) {
// Only let GestureTab in (we only need it and we know
// PlatformGestureEventBuilder supports it).
PlatformGestureEvent gestureEvent = PlatformGestureEventBuilder(
@@ -245,8 +245,8 @@ bool InspectorOverlay::handleInputEvent(const WebInputEvent& inputEvent) {
overlayMainFrame()->eventHandler().handleGestureEvent(gestureEvent);
}
- if (WebInputEvent::isMouseEventType(inputEvent.type) &&
- inputEvent.type != WebInputEvent::MouseEnter) {
+ if (WebInputEvent::isMouseEventType(inputEvent.type()) &&
+ inputEvent.type() != WebInputEvent::MouseEnter) {
// PlatformMouseEventBuilder does not work with MouseEnter type, so we
// filter it out manually.
PlatformMouseEvent mouseEvent = PlatformMouseEventBuilder(
@@ -276,7 +276,7 @@ bool InspectorOverlay::handleInputEvent(const WebInputEvent& inputEvent) {
mouseEvent) != WebInputEventResult::NotHandled;
}
- if (WebInputEvent::isTouchEventType(inputEvent.type)) {
+ if (WebInputEvent::isTouchEventType(inputEvent.type())) {
PlatformTouchEvent touchEvent = PlatformTouchEventBuilder(
m_frameImpl->frameView(),
static_cast<const WebTouchEvent&>(inputEvent));
@@ -288,12 +288,12 @@ bool InspectorOverlay::handleInputEvent(const WebInputEvent& inputEvent) {
createPlatformTouchEventVector(m_frameImpl->frameView(),
std::vector<const WebInputEvent*>()));
}
- if (WebInputEvent::isKeyboardEventType(inputEvent.type)) {
+ if (WebInputEvent::isKeyboardEventType(inputEvent.type())) {
overlayMainFrame()->eventHandler().keyEvent(
static_cast<const WebKeyboardEvent&>(inputEvent));
}
- if (inputEvent.type == WebInputEvent::MouseWheel) {
+ if (inputEvent.type() == WebInputEvent::MouseWheel) {
PlatformWheelEvent wheelEvent = PlatformWheelEventBuilder(
m_frameImpl->frameView(),
static_cast<const WebMouseWheelEvent&>(inputEvent));

Powered by Google App Engine
This is Rietveld 408576698