Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1161)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
index 9b15c9cc38e2041b3fadf35e118173d53c671cd7..37cc2abe4fd10ab111985273ffb5408f52a9d2fb 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl.cc
@@ -594,9 +594,9 @@ bool RendererSchedulerImpl::ShouldPrioritizeInputEvent(
const blink::WebInputEvent& web_input_event) {
// We regard MouseMove events with the left mouse button down as a signal
// that the user is doing something requiring a smooth frame rate.
- if ((web_input_event.type == blink::WebInputEvent::MouseDown ||
- web_input_event.type == blink::WebInputEvent::MouseMove) &&
- (web_input_event.modifiers & blink::WebInputEvent::LeftButtonDown)) {
+ if ((web_input_event.type() == blink::WebInputEvent::MouseDown ||
+ web_input_event.type() == blink::WebInputEvent::MouseMove) &&
+ (web_input_event.modifiers() & blink::WebInputEvent::LeftButtonDown)) {
return true;
}
// Ignore all other mouse events because they probably don't signal user
@@ -604,8 +604,8 @@ bool RendererSchedulerImpl::ShouldPrioritizeInputEvent(
// for mouse wheel events, hence we regard them as user input.
// Ignore keyboard events because it doesn't really make sense to enter
// compositor priority for them.
- if (blink::WebInputEvent::isMouseEventType(web_input_event.type) ||
- blink::WebInputEvent::isKeyboardEventType(web_input_event.type)) {
+ if (blink::WebInputEvent::isMouseEventType(web_input_event.type()) ||
+ blink::WebInputEvent::isKeyboardEventType(web_input_event.type())) {
return false;
}
return true;
@@ -619,7 +619,7 @@ void RendererSchedulerImpl::DidHandleInputEventOnCompositorThread(
if (!ShouldPrioritizeInputEvent(web_input_event))
return;
- UpdateForInputEventOnCompositorThread(web_input_event.type, event_state);
+ UpdateForInputEventOnCompositorThread(web_input_event.type(), event_state);
}
void RendererSchedulerImpl::DidAnimateForInputOnCompositorThread() {

Powered by Google App Engine
This is Rietveld 408576698