chrome/browser/ui/autofill/autofill_popup_controller_impl.cc - Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 2573073003: Collapse the API surface on WebInputEvent via accessor functions. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

index 169aac1f459bbe56db494e989cd41a4d5daa1bd3..fc04ca072809c9d1cab1e4f71cf590e5f7f91045 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

@@ -231,7 +231,7 @@ bool AutofillPopupControllerImpl::HandleKeyPressEvent(

Hide();

return true;

case ui::VKEY_DELETE:

- return (event.modifiers & content::NativeWebKeyboardEvent::ShiftKey) &&

+ return (event.modifiers() & content::NativeWebKeyboardEvent::ShiftKey) &&

RemoveSelectedLine();

case ui::VKEY_TAB:

// A tab press should cause the selected line to be accepted, but still