Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Side by Side Diff: chrome/test/base/tracing_browsertest.cc

Issue 2573063002: Disable flaky TracingBrowserTest.TestMemoryInfra on all platforms. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/base/tracing.h" 5 #include "chrome/test/base/tracing.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/run_loop.h" 9 #include "base/run_loop.h"
10 #include "base/single_thread_task_runner.h" 10 #include "base/single_thread_task_runner.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 std::string json_events; 73 std::string json_events;
74 ASSERT_TRUE(EndTracing(&json_events)); 74 ASSERT_TRUE(EndTracing(&json_events));
75 75
76 // Expect the basic memory dumps to be present in the trace. 76 // Expect the basic memory dumps to be present in the trace.
77 EXPECT_NE(std::string::npos, json_events.find("process_totals")); 77 EXPECT_NE(std::string::npos, json_events.find("process_totals"));
78 EXPECT_NE(std::string::npos, json_events.find("v8")); 78 EXPECT_NE(std::string::npos, json_events.find("v8"));
79 EXPECT_NE(std::string::npos, json_events.find("blink_gc")); 79 EXPECT_NE(std::string::npos, json_events.find("blink_gc"));
80 } 80 }
81 }; 81 };
82 82
83 // Flaky on Linux. http://crbug.com/658054 83 // Flaky: http://crbug.com/658054
84 #if defined(OS_LINUX) 84 IN_PROC_BROWSER_TEST_F(TracingBrowserTest, DISABLED_TestMemoryInfra) {
85 #define MAYBE_TestMemoryInfra DISABLED_TestMemoryInfra
86 #else
87 #define MAYBE_TestMemoryInfra TestMemoryInfra
88 #endif
89
90 IN_PROC_BROWSER_TEST_F(TracingBrowserTest, MAYBE_TestMemoryInfra) {
91 PerformDumpMemoryTestActions(base::trace_event::TraceConfig( 85 PerformDumpMemoryTestActions(base::trace_event::TraceConfig(
92 base::trace_event::TraceConfigMemoryTestUtil:: 86 base::trace_event::TraceConfigMemoryTestUtil::
93 GetTraceConfig_PeriodicTriggers(250, 2000))); 87 GetTraceConfig_PeriodicTriggers(250, 2000)));
94 } 88 }
95 89
96 IN_PROC_BROWSER_TEST_F(TracingBrowserTest, TestBackgroundMemoryInfra) { 90 // Flaky: http://crbug.com/658054
91 IN_PROC_BROWSER_TEST_F(TracingBrowserTest, DISABLED_TestBackgroundMemoryInfra) {
97 PerformDumpMemoryTestActions(base::trace_event::TraceConfig( 92 PerformDumpMemoryTestActions(base::trace_event::TraceConfig(
98 base::trace_event::TraceConfigMemoryTestUtil:: 93 base::trace_event::TraceConfigMemoryTestUtil::
99 GetTraceConfig_BackgroundTrigger(200))); 94 GetTraceConfig_BackgroundTrigger(200)));
100 } 95 }
101 96
102 } // namespace 97 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698