Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Issue 25730004: Git rid of translator_glsl dependency. (Closed)

Created:
7 years, 2 months ago by Zhenyao Mo
Modified:
7 years, 2 months ago
CC:
blink-reviews
Visibility:
Public.

Description

Git rid of translator_glsl dependency. We switch to use translator in ANGLE. At the moment translator_glsl is simply a duplication of translator. BUG= TEST=tree R=jamesr@chromium.org, kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=158835

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/core/core.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/web/web.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Zhenyao Mo
kbr: please review. jamesr: web/ owner review.
7 years, 2 months ago (2013-10-02 23:56:59 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
7 years, 2 months ago (2013-10-03 00:07:56 UTC) #2
jamesr
lgtm
7 years, 2 months ago (2013-10-03 00:13:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/25730004/1
7 years, 2 months ago (2013-10-03 14:55:14 UTC) #4
Zhenyao Mo
7 years, 2 months ago (2013-10-03 19:04:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r158835 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698