Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc

Issue 2572893002: [Reland] Dont post delayed DoWork for disabled queues. (Closed)
Patch Set: Fix compile Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
index d5fdb53a7fc929637ab09646c3c750ecd67a0088..79cef1c6244f84d61a0c8960f4472ce81d3869ff 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/task_queue_throttler_unittest.cc
@@ -979,5 +979,41 @@ TEST_F(TaskQueueThrottlerTest, AddQueueToBudgetPoolWhenThrottlingDisabled) {
base::TimeDelta::FromMilliseconds(300)));
}
+TEST_F(TaskQueueThrottlerTest, DisabledQueueThenEnabledQueue) {
+ std::vector<base::TimeTicks> run_times;
+
+ scoped_refptr<TaskQueue> second_queue =
+ scheduler_->NewTimerTaskRunner(TaskQueue::QueueType::TEST);
+
+ task_queue_throttler_->IncreaseThrottleRefCount(timer_queue_.get());
+ task_queue_throttler_->IncreaseThrottleRefCount(second_queue.get());
+
+ timer_queue_->PostDelayedTask(FROM_HERE,
+ base::Bind(&TestTask, &run_times, clock_.get()),
+ base::TimeDelta::FromMilliseconds(100));
+ second_queue->PostDelayedTask(FROM_HERE,
+ base::Bind(&TestTask, &run_times, clock_.get()),
+ base::TimeDelta::FromMilliseconds(200));
+
+ std::unique_ptr<TaskQueue::QueueEnabledVoter> voter =
+ timer_queue_->CreateQueueEnabledVoter();
+ voter->SetQueueEnabled(false);
+
+ clock_->Advance(base::TimeDelta::FromMilliseconds(250));
+
+ mock_task_runner_->RunUntilIdle();
+
+ EXPECT_THAT(run_times, ElementsAre(base::TimeTicks() +
+ base::TimeDelta::FromMilliseconds(1000)));
+
+ voter->SetQueueEnabled(true);
+ mock_task_runner_->RunUntilIdle();
+
+ EXPECT_THAT(
+ run_times,
+ ElementsAre(base::TimeTicks() + base::TimeDelta::FromMilliseconds(1000),
+ base::TimeTicks() + base::TimeDelta::FromMilliseconds(2000)));
+}
+
} // namespace scheduler
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698