Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1448)

Unified Diff: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc

Issue 2572893002: [Reland] Dont post delayed DoWork for disabled queues. (Closed)
Patch Set: Rebased Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
index f8eaf85248b9d070cb12a7625f0a2f9b0e84ded5..0337330a0422ce0b6ebbb9a95256511a2808c22e 100644
--- a/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/base/time_domain_unittest.cc
@@ -53,7 +53,10 @@ class MockTimeDomain : public TimeDomain {
void OnRegisterWithTaskQueueManager(
TaskQueueManager* task_queue_manager) override {}
- MOCK_METHOD2(RequestWakeup, void(base::TimeTicks now, base::TimeDelta delay));
+ MOCK_METHOD2(RequestWakeupAt,
+ void(LazyNow* lazy_now, base::TimeTicks run_time));
+
+ MOCK_METHOD1(CancelWakeupAt, void(base::TimeTicks run_time));
void SetNow(base::TimeTicks now) { now_ = now; }
@@ -89,9 +92,10 @@ class TimeDomainTest : public testing::Test {
TEST_F(TimeDomainTest, ScheduleDelayedWork) {
base::TimeDelta delay = base::TimeDelta::FromMilliseconds(10);
base::TimeTicks delayed_runtime = time_domain_->Now() + delay;
- EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay));
- base::TimeTicks now = time_domain_->Now();
- time_domain_->ScheduleDelayedWork(task_queue_.get(), now + delay, now);
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, delayed_runtime));
+ LazyNow lazy_now = time_domain_->CreateLazyNow();
+ time_domain_->ScheduleDelayedWork(task_queue_.get(), lazy_now.Now() + delay,
+ &lazy_now);
base::TimeTicks next_scheduled_runtime;
EXPECT_TRUE(time_domain_->NextScheduledRunTime(&next_scheduled_runtime));
@@ -107,9 +111,10 @@ TEST_F(TimeDomainTest, ScheduleDelayedWorkSupersedesPreviousWakeup) {
base::TimeDelta delay2 = base::TimeDelta::FromMilliseconds(100);
base::TimeTicks delayed_runtime1 = time_domain_->Now() + delay1;
base::TimeTicks delayed_runtime2 = time_domain_->Now() + delay2;
- EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay1));
- base::TimeTicks now = time_domain_->Now();
- time_domain_->ScheduleDelayedWork(task_queue_.get(), delayed_runtime1, now);
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, delayed_runtime1));
+ LazyNow lazy_now = time_domain_->CreateLazyNow();
+ time_domain_->ScheduleDelayedWork(task_queue_.get(), delayed_runtime1,
+ &lazy_now);
base::TimeTicks next_scheduled_runtime;
EXPECT_TRUE(time_domain_->NextScheduledRunTime(&next_scheduled_runtime));
@@ -119,14 +124,15 @@ TEST_F(TimeDomainTest, ScheduleDelayedWorkSupersedesPreviousWakeup) {
// Now scheduler a later wakeup, which should replace the previously requested
// one.
- EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay2));
- time_domain_->ScheduleDelayedWork(task_queue_.get(), delayed_runtime2, now);
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, delayed_runtime2));
+ time_domain_->ScheduleDelayedWork(task_queue_.get(), delayed_runtime2,
+ &lazy_now);
EXPECT_TRUE(time_domain_->NextScheduledRunTime(&next_scheduled_runtime));
EXPECT_EQ(delayed_runtime2, next_scheduled_runtime);
}
-TEST_F(TimeDomainTest, RequestWakeup_OnlyCalledForEarlierTasks) {
+TEST_F(TimeDomainTest, RequestWakeupAt_OnlyCalledForEarlierTasks) {
scoped_refptr<internal::TaskQueueImpl> task_queue2 = make_scoped_refptr(
new internal::TaskQueueImpl(nullptr, time_domain_.get(),
TaskQueue::Spec(TaskQueue::QueueType::TEST),
@@ -147,23 +153,31 @@ TEST_F(TimeDomainTest, RequestWakeup_OnlyCalledForEarlierTasks) {
base::TimeDelta delay3 = base::TimeDelta::FromMilliseconds(30);
base::TimeDelta delay4 = base::TimeDelta::FromMilliseconds(1);
- // RequestWakeup should always be called if there are no other wakeups.
- EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay1));
- base::TimeTicks now = time_domain_->Now();
- time_domain_->ScheduleDelayedWork(task_queue_.get(), now + delay1, now);
+ // RequestWakeupAt should always be called if there are no other wakeups.
+ LazyNow lazy_now = time_domain_->CreateLazyNow();
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, lazy_now.Now() + delay1));
+ time_domain_->ScheduleDelayedWork(task_queue_.get(), lazy_now.Now() + delay1,
+ &lazy_now);
Mock::VerifyAndClearExpectations(time_domain_.get());
- // RequestWakeup should not be called when scheduling later tasks.
- EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _)).Times(0);
- time_domain_->ScheduleDelayedWork(task_queue2.get(), now + delay2, now);
- time_domain_->ScheduleDelayedWork(task_queue3.get(), now + delay3, now);
+ // RequestWakeupAt should not be called when scheduling later tasks.
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, _)).Times(0);
+ time_domain_->ScheduleDelayedWork(task_queue2.get(), lazy_now.Now() + delay2,
+ &lazy_now);
+ time_domain_->ScheduleDelayedWork(task_queue3.get(), lazy_now.Now() + delay3,
+ &lazy_now);
- // RequestWakeup should be called when scheduling earlier tasks.
+ // RequestWakeupAt should be called when scheduling earlier tasks.
Mock::VerifyAndClearExpectations(time_domain_.get());
- EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay4));
- time_domain_->ScheduleDelayedWork(task_queue4.get(), now + delay4, now);
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, lazy_now.Now() + delay4));
+ time_domain_->ScheduleDelayedWork(task_queue4.get(), lazy_now.Now() + delay4,
+ &lazy_now);
+ Mock::VerifyAndClearExpectations(time_domain_.get());
+
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, _));
+ EXPECT_CALL(*time_domain_.get(), CancelWakeupAt(_)).Times(2);
task_queue2->UnregisterTaskQueue();
task_queue3->UnregisterTaskQueue();
task_queue4->UnregisterTaskQueue();
@@ -175,38 +189,49 @@ TEST_F(TimeDomainTest, UnregisterQueue) {
TaskQueue::Spec(TaskQueue::QueueType::TEST),
"test.category", "test.category"));
- EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _)).Times(1);
- base::TimeTicks now = time_domain_->Now();
- time_domain_->ScheduleDelayedWork(
- task_queue_.get(), now + base::TimeDelta::FromMilliseconds(10), now);
- time_domain_->ScheduleDelayedWork(
- task_queue2_.get(), now + base::TimeDelta::FromMilliseconds(100), now);
+ LazyNow lazy_now = time_domain_->CreateLazyNow();
+ base::TimeTicks wakeup1 =
+ lazy_now.Now() + base::TimeDelta::FromMilliseconds(10);
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, wakeup1)).Times(1);
+ time_domain_->ScheduleDelayedWork(task_queue_.get(), wakeup1, &lazy_now);
+ base::TimeTicks wakeup2 =
+ lazy_now.Now() + base::TimeDelta::FromMilliseconds(100);
+ time_domain_->ScheduleDelayedWork(task_queue2_.get(), wakeup2, &lazy_now);
TaskQueue* next_task_queue;
EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
EXPECT_EQ(task_queue_.get(), next_task_queue);
+ testing::Mock::VerifyAndClearExpectations(time_domain_.get());
+
+ EXPECT_CALL(*time_domain_.get(), CancelWakeupAt(wakeup1)).Times(1);
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, wakeup2)).Times(1);
+
time_domain_->UnregisterQueue(task_queue_.get());
task_queue_ = scoped_refptr<internal::TaskQueueImpl>();
EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
EXPECT_EQ(task_queue2_.get(), next_task_queue);
+ testing::Mock::VerifyAndClearExpectations(time_domain_.get());
+
+ EXPECT_CALL(*time_domain_.get(), CancelWakeupAt(wakeup2)).Times(1);
+
time_domain_->UnregisterQueue(task_queue2_.get());
EXPECT_FALSE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
}
TEST_F(TimeDomainTest, WakeupReadyDelayedQueues) {
base::TimeDelta delay = base::TimeDelta::FromMilliseconds(50);
- EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, delay));
- base::TimeTicks now = time_domain_->Now();
- base::TimeTicks delayed_runtime = now + delay;
- time_domain_->ScheduleDelayedWork(task_queue_.get(), delayed_runtime, now);
+ LazyNow lazy_now = time_domain_->CreateLazyNow();
+ base::TimeTicks delayed_runtime = lazy_now.Now() + delay;
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, delayed_runtime));
+ time_domain_->ScheduleDelayedWork(task_queue_.get(), delayed_runtime,
+ &lazy_now);
base::TimeTicks next_run_time;
ASSERT_TRUE(time_domain_->NextScheduledRunTime(&next_run_time));
EXPECT_EQ(delayed_runtime, next_run_time);
- LazyNow lazy_now = time_domain_->CreateLazyNow();
time_domain_->WakeupReadyDelayedQueues(&lazy_now);
ASSERT_TRUE(time_domain_->NextScheduledRunTime(&next_run_time));
EXPECT_EQ(delayed_runtime, next_run_time);
@@ -218,9 +243,10 @@ TEST_F(TimeDomainTest, WakeupReadyDelayedQueues) {
}
TEST_F(TimeDomainTest, CancelDelayedWork) {
- base::TimeTicks now = time_domain_->Now();
+ LazyNow lazy_now = time_domain_->CreateLazyNow();
time_domain_->ScheduleDelayedWork(
- task_queue_.get(), now + base::TimeDelta::FromMilliseconds(20), now);
+ task_queue_.get(), lazy_now.Now() + base::TimeDelta::FromMilliseconds(20),
+ &lazy_now);
TaskQueue* next_task_queue;
EXPECT_TRUE(time_domain_->NextScheduledTaskQueue(&next_task_queue));
@@ -257,10 +283,11 @@ TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasImmediateWork) {
TEST_F(TimeDomainWithObserverTest, OnTimeDomainHasDelayedWork) {
EXPECT_CALL(*observer_, OnTimeDomainHasDelayedWork(task_queue_.get()));
- EXPECT_CALL(*time_domain_.get(), RequestWakeup(_, _));
- base::TimeTicks now = time_domain_->Now();
+ EXPECT_CALL(*time_domain_.get(), RequestWakeupAt(_, _));
+ LazyNow lazy_now = time_domain_->CreateLazyNow();
time_domain_->ScheduleDelayedWork(
- task_queue_.get(), now + base::TimeDelta::FromMilliseconds(10), now);
+ task_queue_.get(), lazy_now.Now() + base::TimeDelta::FromMilliseconds(10),
+ &lazy_now);
}
} // namespace scheduler

Powered by Google App Engine
This is Rietveld 408576698